Playlist editor stops writing to default.xml and Teardowns happen afterward #1547
Labels
Comments
|
@tylerwatt12 I tested this by importing the MARCS talkgroups into an empty playlist and removing a large chunk of those talkgroups as you suggested, but I'm not able to reproduce any error or to cause the playlist to not be saved. There may be something else going on ... channel teardown issues normally wouldn't be related to playlist save issues, but they could both happen if/when the application is in a degraded state, such as if it runs out of heap space or if there is an I/O error. If you can recreate the scenario/symptoms, can you please send me the application log and we can see if there were any errors logged that might be related to the symptoms you're seeing? |
|
I was able to reproduce it, but I don't get anything out of the log when that happens. I did find the logs from the previous video I uploaded https://www.youtube.com/watch?v=DjuumOdbKrs 20230512 113536.847 [main] INFO i..txt Does sdrtrunk have more verbose debug options? If you want remote access to this VM to test/debug I can accommodate. |
DSheirer
pushed a commit
that referenced
this issue
May 21, 2023
|
@tylerwatt12 I updated the alias editor to make add/delete operations more efficient. I'm not sure if this was contributing to the playlist save failure that you're seeing or not. However, I did notice with that system in partucular that it was taking a long time to both add and to delete. I'll merge these changes to master and close this issue for now. However, if the playlist save issue continues, we can reopen this issue and look into it some more. |
DSheirer
added a commit
that referenced
this issue
May 21, 2023
…e efficient. (#1560) Co-authored-by: Dennis Sheirer <[email protected]>
tadscottsmith
added a commit
to tadscottsmith/sdrtrunk
that referenced
this issue
Aug 7, 2023
* DSheirer#1529 Adds logging suppression to Broadcaster to limit total logged error messages. (DSheirer#1530) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1531 Updates version to 0.6.0 alpha 7 (DSheirer#1532) Co-authored-by: Dennis Sheirer <[email protected]> * Revert "DSheirer#1531 Updates version to 0.6.0 alpha 7 (DSheirer#1532)" This reverts commit 11f37e8. * DSheirer#35 Updates AM & NBFM decoders to use Adaptive Squelch, a power squelch that includes an adaptive noise floor monitor. Implements vectorized magnitude operations for AM & FM decoders. Adds talkgroup assignment and squelch controls to AM channel configuration editor. Implements new AM gain control that attempts to normalize audio gain quickly at beginning of call/transmission and maintains that gain across lifecycle of the call and resets the gain for the next call. (DSheirer#1540) Notes on usage: - When using either AM or FM squelch control use either the Heterodyne channelizer or if using the Polyphase channelizer, avoid using trunk tracking decoders like DMR or P25 or set the squelch threshold high enough to avoid changes in noise floor from polyphase channelizer where it can vary between using the one channel or the two-channel combined channel sources. Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1528 Restores consistent audio segment start tone insertion, broken in DSheirer#1506 (DSheirer#1543) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#648 Resolves issue with audio panel sometimes displaying stale metadata that doesn't clear until the next audio segment is loaded. (DSheirer#1545) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1507 Resolves issue with Cap+ LSN parsing. Updates Cap+ Site Status and adds RAS bit handling. (DSheirer#1536) Co-authored-by: Matthew Foster <[email protected]> * Adds native Rdio Scanner streaming. (#1) (DSheirer#1476) DSheirer#1476 Adds rdio-scanner call upload API streaming support --------- Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1556 DMR Capacity Plus parsing enhancements. (DSheirer#1557) Co-authored-by: Dennis Sheirer <[email protected]> * added Rsp1TunerConfiguration to JsonSubTypes of RspTunerConfiguration (DSheirer#1555) Following reports that RSP1 tuner configurations are reset to default on startup. Unable to test * DSheirer#1548 Reduces default decoder AF gain by 40% to resolve issue with distorted audio from local strong aircraft transmissions. (DSheirer#1559) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1547 Updates playlist alias editor to make add/delete operations more efficient. (DSheirer#1560) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1558 Resolves issue where heterodyne channelizer allows tuning a set of channels that exceed the tuner's bandwidth. (DSheirer#1561) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1565 updates LTR, LTRNet and Passport decoders with new slope decoder. Resolves issue with LTR Standard decoder state that was combining individual calls to the same talkgroup and causing excessively long calls. (DSheirer#1567) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1568 Updates NBFM decoder configuration so user can enable/disable high-pass filter option in the audio module to effect audio playback and audio recording of the demodulated audio. Disabling the filter allows recording of DC and sub-audible signalling that may be present in the demodulated audio (e.g. LTR or squelching signalling). (DSheirer#1569) Co-authored-by: sheirerd <[email protected]> * DSheirer#1573 Adds Digital Coded Squelch (DCS) auxiliary decoder support. (DSheirer#1574) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1575 Updates traffic channel names to be 'T-' concatenated with the parent control channel name from the channel configuration. (DSheirer#1578) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1579 Resolves issue with array index out of bounds error generated in P25 Phase 1 decoders where the Dibit circular buffer attempts to write a (DSheirer#1580) dibit past the length of the array. Issue likely occurs when a partial/incomplete put operation adds a dibit and increments the buffer pointer but the thread is interrupted prior to wrapping the buffer pointer. When the next runnable iteration executes, the pointer is pointing past the end of the buffer. Updates the code to check the pointer both before and after the put operation. Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1581 Updates Rdio Scanner configuration editor to automatically append the 'api/call-upload' path to the end of the protocol and host value provided by the user. Sets the host default value to 'http://localhost' but allows the user to overwrite. (DSheirer#1582) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1563 Updates RSP tuner to produce sample buffers with optimal power-of-2 length to enable downstream vectorized operations. (DSheirer#1583) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1584 Updates DMR & P25 decoders to stop processing residual samples from the current buffer after a traffic channel shutdown has been signalled. (DSheirer#1585) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1590 Resolves issue with RSP tuners generating too many native buffers causing excessive memory consumption (DSheirer#1591) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1588 Use JDK20 and Gradle 8.2. Updates SDRPlay API for compatibility with JDK20 Project Panama Foreign Memory/Function changes. (DSheirer#1589) Co-authored-by: Dennis Sheirer <[email protected]> * DSheirer#1586 Resolves issue in P25 message framer where after transmitting the current message the mDataUnitId is set to null and this causes an NPE when subsequent code is executed prior to shutdown of the channel. (DSheirer#1593) Co-authored-by: Dennis Sheirer <[email protected]> * Adds event type as a filtering option in the Events tab * DSheirer#1368 Restructures Message and Event filter framework. * DSheirer#1603 Resolves issue with de-duplicating events to allow call duration values to display correctly and minimize the quantity of duplicate events. * DSheirer#1604 Resolves issue with event panel UI layout creating excess space between history management panel and events table. * DSheirer#1605 Resolves issue where certain Linux users were unable to display the tuner editor panel due to an issue with the frequency control editor's usage of custom cursor. * DSheirer#1612 Enhance aliasing to support DCS tones --------- Co-authored-by: Denny Sheirer <[email protected]> Co-authored-by: Dennis Sheirer <[email protected]> Co-authored-by: wedgef5 <[email protected]> Co-authored-by: Matthew Foster <[email protected]> Co-authored-by: Nokoa <[email protected]> Co-authored-by: sheirerd <[email protected]> Co-authored-by: Christopher Varner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sdrtrunk Version
0.5.3
Describe the bug
When I make large changes to aliases, at some point the default.xml file will stop updating until I completely reopen sdrtrunk
When I go to close and re-open the program, none of the changes I made since it stopped writing are displayed.
Also noticed Teardowns start to occur after default.xml stops being written to
See video https://youtu.be/CWN9M_ATvEQ?t=390
(Start at 6:30)
This video shows what happens a little clearer
https://www.youtube.com/watch?v=DjuumOdbKrs
To Reproduce
Import Ohio MARCS-IP from RRDB,
Import all Talkgroups
Delete talkgroups for all except Lorain and Cuyahoga County.
At some point something internally breaks and default.xml isn't updated
Expected behavior
Default.xml updates
Screenshots
If applicable, add screenshots to help explain your problem.
Application Log
If applicable, include either the full application log,or a snippet of the error logging.
Desktop (optional - complete the following information):
Additional context
I initially discovered that my XML file wasn't saving it while trying to parse it. I then noticed the teardowns that would occur when I do anything CPU/File intensive. I'm hoping this helps track down the teardown issue
The text was updated successfully, but these errors were encountered: