#1364 Enhancements to resolve issue with tuner shutdown hang on appli…

…cation shutdown.
DSheirer · Dec 18, 2022 · 0b19efb · 0b19efb
1 parent dc327a2
commit 0b19efb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/main/java/io/github/dsheirer/source/tuner/usb/USBTunerController.java b/src/main/java/io/github/dsheirer/source/tuner/usb/USBTunerController.java
@@ -643,9 +643,14 @@ public void processTransfer(Transfer transfer)
                 default:
                     //Unexpected transfer error - need to reset the bulk transfer interface
                     transfer.buffer().rewind();
-                    setErrorMessage("LibUsb Transfer Error - stopping device - status [" + transfer.status() + "] - " +
-                            LibUsb.errorName(transfer.status()));
-                    return;
+
+                    //Only set an error if we're not shutting down
+                    if(mAutoResubmitTransfers)
+                    {
+                        setErrorMessage("LibUsb Transfer Error - stopping device - status [" + transfer.status() + "] - " +
+                                LibUsb.errorName(transfer.status()));
+                    }
+                    break;
             }
         }
 

diff --git a/src/main/java/io/github/dsheirer/util/Dispatcher.java b/src/main/java/io/github/dsheirer/util/Dispatcher.java
@@ -122,7 +122,8 @@ public void stop()
 
             try
             {
-                mThread.join(2000);
+                mThread.interrupt();
+                mThread.join();
                 mThread = null;
             }
             catch(Exception e)
@@ -183,14 +184,15 @@ else if(element != null)
                     }
                     catch(InterruptedException e)
                     {
-                        mLog.error("Buffer processor thread was interrupted");
+                        //Normal shutdown is by interrupt
                     }
                     catch(Exception e)
                     {
                         mLog.error("Error while processing element", e);
                     }
                 }
 
+                //Shutting down - clear the queue
                 mQueue.clear();
             }
             catch(Throwable t)