-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Rework announcement integration #2181
Conversation
API Changelog 4.17.2.dev24+gd840ec80GET /api/v1/announcements
POST /api/v1/announcements
DELETE /api/v1/announcements/{announcement_id}
GET /api/v1/announcements/{announcement_id}
PATCH /api/v1/announcements/{announcement_id}
GET /api/v1/notices
POST /api/v1/notices
DELETE /api/v1/notices/{notice_id}
GET /api/v1/notices/{notice_id}
GET /api/v1/users/current/tokens
POST /api/v1/users/current/tokens
GET /api/v1/users/{user_id}/permissions
|
I think that the "announcement" name is the best; let's consistently use announcements in Code & UI. |
768e83f
to
50e2757
Compare
A Storybook preview is available for commit d840ec8. |
50e2757
to
820d742
Compare
This comment has been minimized.
This comment has been minimized.
481ec3b
to
ad3afc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
+ Coverage 87.54% 87.56% +0.02%
==========================================
Files 239 239
Lines 8198 8212 +14
Branches 568 569 +1
==========================================
+ Hits 7177 7191 +14
Misses 861 861
Partials 160 160 ☔ View full report in Codecov by Sentry. |
81b806a
to
fae1700
Compare
fae1700
to
195aeec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, love it!
frontend/src/app/settings/core/announcement-settings/announcement-settings.component.html
Show resolved
Hide resolved
frontend/src/app/settings/core/announcement-settings/announcement-settings.component.html
Show resolved
Hide resolved
frontend/src/app/settings/core/announcement-settings/announcement-settings.component.ts
Outdated
Show resolved
Hide resolved
...ore/announcement-settings/edit-announcement/edit-announcement/edit-announcement.component.ts
Outdated
Show resolved
Hide resolved
...ore/announcement-settings/edit-announcement/edit-announcement/edit-announcement.component.ts
Outdated
Show resolved
Hide resolved
...c/app/users/users-profile/reset-hidden-announcements/reset-hidden-announcements.component.ts
Outdated
Show resolved
Hide resolved
195aeec
to
e0ff066
Compare
...e/announcement-settings/edit-announcement/edit-announcement/edit-announcement.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/settings/core/announcement-settings/announcement-settings.component.ts
Outdated
Show resolved
Hide resolved
e0ff066
to
3ced753
Compare
3ced753
to
6416983
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6416983
to
00f97c8
Compare
Bundle ReportChanges will increase total bundle size by 9.42kB (0.07%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: capella-collab-manager-esmAssets Changed:
Files in
|
This comment has been minimized.
This comment has been minimized.
00f97c8
to
0699fe3
Compare
This comment has been minimized.
This comment has been minimized.
0699fe3
to
4b60525
Compare
|
This report was generated by comparing d840ec8 with f6d652b. ArtifactName:
|
item | count |
---|---|
pass | 446 |
change | 8 |
new | 24 |
delete | 10 |
📝 Report
Differences
Identity Provider Error_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Identity Provider Error_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Login_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Login_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Logout_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Logout_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Session Expired_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Session Expired_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
New Items
All Levels_desktop.png
![]() |
All Levels_mobile.png
![]() |
Dismissed Announcements_desktop.png
![]() |
Dismissed Announcements_mobile.png
![]() |
Logo Loading_desktop.png
![]() |
Logo Loading_mobile.png
![]() |
Narrow Logo_desktop.png
![]() |
Narrow Logo_mobile.png
![]() |
No Badge_desktop.png
![]() |
No Badge_mobile.png
![]() |
Loading_desktop.png
![]() |
Loading_mobile.png
![]() |
No Announcements_desktop.png
![]() |
No Announcements_mobile.png
![]() |
Some Announcements_desktop.png
![]() |
Some Announcements_mobile.png
![]() |
Dismissed Announcement That Is No Longer Visible_desktop.png
![]() |
Dismissed Announcement That Is No Longer Visible_mobile.png
![]() |
No Dismissed Announcements_desktop.png
![]() |
No Dismissed Announcements_mobile.png
![]() |
One Dismissed Announcement_desktop.png
![]() |
One Dismissed Announcement_mobile.png
![]() |
Two Dismissed Announcements_desktop.png
![]() |
Two Dismissed Announcements_mobile.png
![]() |
Deleted Items
All Levels_desktop.png
![]() |
All Levels_mobile.png
![]() |
Alert Expanded_desktop.png
![]() |
Alert Expanded_mobile.png
![]() |
Loading_desktop.png
![]() |
Loading_mobile.png
![]() |
No Alerts_desktop.png
![]() |
No Alerts_mobile.png
![]() |
Some Alerts_desktop.png
![]() |
Some Alerts_mobile.png
![]() |
This PR does a couple of different things