Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Upstream Microsoft Pylint Action #74

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

IsaacMilarky
Copy link
Collaborator

Use Upstream Microsoft Pylint Action

Problem

Previously, I used an upstream action to create the checks themselves but not to run Pylint to create content for the check annotations.

Solution

Now, I use an upstream GitHub action developed by Microsoft to run Pylint on this project.

Result

Redundant development is avoided on this in the future.

@IsaacMilarky
Copy link
Collaborator Author

Also some good linting alternatives are listed in the readme for the reviewdog repo

Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@natalialuzuriaga
Copy link
Collaborator

natalialuzuriaga commented Jan 23, 2024

Just looked into reviewdog and I'm definitely thinking about using it to run ESlint for the frontend

@IsaacMilarky IsaacMilarky merged commit 183f71d into dev Jan 23, 2024
2 checks passed
@IsaacMilarky IsaacMilarky deleted the use-upstream-microsoft-pylint-action branch January 23, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants