Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support tableformer model choice #90

Merged
merged 10 commits into from
Sep 26, 2024
Merged

feat: Support tableformer model choice #90

merged 10 commits into from
Sep 26, 2024

Conversation

cau-git
Copy link
Contributor

@cau-git cau-git commented Sep 19, 2024 •
edited
Loading

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@cau-git
Support tableformer model choice
14dcba1 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git force-pushed the cau/tableformer-configuration branch from 5b131d2 to 14dcba1 Compare September 19, 2024 13:27
@cau-git
Update datamodel structure
d8163b0 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git
Update docs
6ea6f29 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git force-pushed the cau/tableformer-configuration branch 2 times, most recently from 33a4e2c to d57c65d Compare September 19, 2024 15:06
@cau-git
Cleanup
f6edd92 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git force-pushed the cau/tableformer-configuration branch from d57c65d to f6edd92 Compare September 19, 2024 15:08
@cau-git cau-git requested a review from dolfim-ibm September 19, 2024 15:09
@cau-git cau-git marked this pull request as draft September 19, 2024 15:10
@cau-git
Add test unit for table options
5369c55 
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git force-pushed the cau/tableformer-configuration branch from b154d46 to 5369c55 Compare September 19, 2024 16:41
@cau-git cau-git marked this pull request as ready for review September 23, 2024 17:50
maxmnemonic
maxmnemonic previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@maxmnemonic maxmnemonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model switching works well, great, thanks @cau-git !

dolfim-ibm
dolfim-ibm requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change.

@maxmnemonic maxmnemonic self-requested a review September 25, 2024 14:35
@cau-git cau-git requested a review from dolfim-ibm September 26, 2024 11:46
@cau-git
Update README
78db47d 
Signed-off-by: Christoph Auer <[email protected]>
maxmnemonic
maxmnemonic previously approved these changes Sep 26, 2024
View reviewed changes
@cau-git cau-git requested a review from maxmnemonic September 26, 2024 15:45
@cau-git
Update Dockerfile
ba1001d 
Signed-off-by: Christoph Auer <[email protected]>
dolfim-ibm
dolfim-ibm approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cau-git cau-git merged commit d6df76f into main Sep 26, 2024
4 checks passed
@cau-git cau-git deleted the cau/tableformer-configuration branch September 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfim-ibm dolfim-ibm dolfim-ibm approved these changes

@maxmnemonic maxmnemonic Awaiting requested review from maxmnemonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cau-git @dolfim-ibm @maxmnemonic