Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix correct Accelerator pipeline options in docs/examples/custom_convert.py #733

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

Ighina
Copy link
Contributor

@Ighina Ighina commented Jan 13, 2025

fix[docs/examples/custom_convert.py]: Added the missing AcceleratorDevice and AcceleratorOptions functions in the imports and changed Device in the code to the correct AcceleratorDevice.

Checklist:

  • [ x] Documentation has been updated, if necessary.
  • [ x] Examples have been added, if necessary.
  • [ x] Tests have been added, if necessary.

Added the missing AcceleratorDevice and AcceleratorOptions functions in the imports and changed Device in the code to the correct AcceleratorDevice

Signed-off-by: Iacopo Ghinassi <[email protected]>
Copy link

mergify bot commented Jan 13, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@Ighina Ighina changed the title Update custom_convert.py fix: correct Accelerator pipeline options in docs/examples/custom_convert.py Jan 13, 2025
@cau-git
Copy link
Contributor

cau-git commented Jan 14, 2025

@Ighina Thanks for this fix. Could you please run the pre-commit toolchain to ensure the tests can pass?

  1. Make sure you installed pre-commit, i.e. poetry run pre-commit install
  2. Make a dummy commit with no changes to run the toolchain.

@vagenas
Copy link
Contributor

vagenas commented Jan 14, 2025

FYI reported in #724.

@dolfim-ibm dolfim-ibm changed the title fix: correct Accelerator pipeline options in docs/examples/custom_convert.py docs: fix correct Accelerator pipeline options in docs/examples/custom_convert.py Jan 17, 2025
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm self-requested a review January 17, 2025 15:22
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cau-git cau-git merged commit 7686083 into DS4SD:main Jan 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants