fix: Fixes for wordx #432
Merged
fix: Fixes for wordx #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Lysak <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Closed
…blob. Added explicit dependency on lxml. Signed-off-by: Maksym Lysak <[email protected]>
…tests for docx, eased up dependency on lxml Signed-off-by: Maksym Lysak <[email protected]>
cau-git
reviewed
Nov 26, 2024
Signed-off-by: Maksym Lysak <[email protected]>
Manuel030
pushed a commit
to Manuel030/docling
that referenced
this pull request
Nov 27, 2024
* fixes for referencing drawing blip in wordx Signed-off-by: Maksym Lysak <[email protected]> * Added safety try-except when trying to load pillow image from a docx blob. Added explicit dependency on lxml. Signed-off-by: Maksym Lysak <[email protected]> * Added test for word file with embedded emf images, re-generated full tests for docx, eased up dependency on lxml Signed-off-by: Maksym Lysak <[email protected]> * Updated lxml dependency version Signed-off-by: Maksym Lysak <[email protected]> --------- Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]>
Manuel030
pushed a commit
to Manuel030/docling
that referenced
this pull request
Nov 27, 2024
* fixes for referencing drawing blip in wordx Signed-off-by: Maksym Lysak <[email protected]> * Added safety try-except when trying to load pillow image from a docx blob. Added explicit dependency on lxml. Signed-off-by: Maksym Lysak <[email protected]> * Added test for word file with embedded emf images, re-generated full tests for docx, eased up dependency on lxml Signed-off-by: Maksym Lysak <[email protected]> * Updated lxml dependency version Signed-off-by: Maksym Lysak <[email protected]> --------- Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]> Signed-off-by: Manuel030 <[email protected]>
maxmnemonic
added a commit
that referenced
this pull request
Nov 27, 2024
* fix image index in word backend Signed-off-by: Manuel030 <[email protected]> * fix: Fixes for wordx (#432) * fixes for referencing drawing blip in wordx Signed-off-by: Maksym Lysak <[email protected]> * Added safety try-except when trying to load pillow image from a docx blob. Added explicit dependency on lxml. Signed-off-by: Maksym Lysak <[email protected]> * Added test for word file with embedded emf images, re-generated full tests for docx, eased up dependency on lxml Signed-off-by: Maksym Lysak <[email protected]> * Updated lxml dependency version Signed-off-by: Maksym Lysak <[email protected]> --------- Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]> Signed-off-by: Manuel030 <[email protected]> * sign dco Signed-off-by: Manuel030 <[email protected]> * correct rebase error Signed-off-by: Manuel030 <[email protected]> --------- Signed-off-by: Manuel030 <[email protected]> Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Maxim Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #417
Resolves #410
Checklist: