fix: use correct image index in word backend #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
@Manuel030 Thanks for this, we will review. To get the checks green, can you please re-sign all commits with DCO (it doesn't help if only the last one is signed). |
|
@Manuel030 thanks for this! I'll run it through some extra docs just to be sure it works cleanly |
maxmnemonic
previously approved these changes
Nov 27, 2024
|
@Manuel030 code looks fine, and indeed corrects the position of image appearance, can you please sign off your commits for this PR, as @cau-git mentioned: then we could merge it |
Manuel030
force-pushed
the
fix-image-location
branch
2 times, most recently
from
972e27d to
c02bbc8
Compare
Signed-off-by: Manuel030 <[email protected]>
* fixes for referencing drawing blip in wordx Signed-off-by: Maksym Lysak <[email protected]> * Added safety try-except when trying to load pillow image from a docx blob. Added explicit dependency on lxml. Signed-off-by: Maksym Lysak <[email protected]> * Added test for word file with embedded emf images, re-generated full tests for docx, eased up dependency on lxml Signed-off-by: Maksym Lysak <[email protected]> * Updated lxml dependency version Signed-off-by: Maksym Lysak <[email protected]> --------- Signed-off-by: Maksym Lysak <[email protected]> Co-authored-by: Maksym Lysak <[email protected]> Signed-off-by: Manuel030 <[email protected]>
Signed-off-by: Manuel030 <[email protected]>
Signed-off-by: Manuel030 <[email protected]>
Manuel030
force-pushed
the
fix-image-location
branch
from
c02bbc8 to
cf2f3a1
Compare
Signed-off-by: Manuel030 <[email protected]>
|
Got it 👍 And sorry for the Git confusion :) |
dolfim-ibm
approved these changes
Nov 27, 2024
maxmnemonic
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #441
Checklist: