feat: extend chunk meta with schema, version, origin #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Panos Vagenas <[email protected]>
ceberam
approved these changes
Oct 22, 2024
Comment on lines
+91
to
+103
| def check_version_is_compatible(cls, v: str) -> str: | ||
| """Check if this meta item version is compatible with current version.""" | ||
| current_match = re.match(VERSION_PATTERN, _VERSION) | ||
| doc_match = re.match(VERSION_PATTERN, v) | ||
| if ( | ||
| doc_match is None | ||
| or current_match is None | ||
| or doc_match["major"] != current_match["major"] | ||
| or doc_match["minor"] > current_match["minor"] | ||
| ): | ||
| raise ValueError(f"incompatible version {v} with schema version {_VERSION}") | ||
| else: | ||
| return _VERSION |
There was a problem hiding this comment.
we should reuse the validator in https://github.com/DS4SD/docling-core/blob/main/docling_core/types/doc/document.py#L1418 to avoid code duplication
There was a problem hiding this comment.
Good point, will just need to account for the fact that a validator parameter for target version should be included too as it is different for the two cases (pydantic/pydantic#2938)
|
|
||
| schema_name: Literal["docling_core.transforms.chunker.DocMeta"] = Field( |
There was a problem hiding this comment.
Agree with setting a full path to mark the schema. We may want to do the same with DoclingDocument schema name on https://github.com/DS4SD/docling-core/blob/main/docling_core/types/doc/document.py#L784
dolfim-ibm
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.