Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: annotate **kwargs in HybridChunker.chunk #116

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Fogapod
Copy link
Contributor

@Fogapod Fogapod commented Dec 18, 2024

strict pyright forbids calling this function with missing annotation

Copy link

mergify bot commented Dec 18, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@Fogapod Fogapod changed the title annotate **kwargs in HybridChunker.chunk chore: annotate **kwargs in HybridChunker.chunk Dec 18, 2024
@dolfim-ibm dolfim-ibm requested a review from vagenas January 6, 2025 09:19
@vagenas vagenas self-assigned this Jan 10, 2025
@Fogapod
Copy link
Contributor Author

Fogapod commented Jan 17, 2025

CI failures look unrelated. It's failing at numpy imports

@dolfim-ibm
Copy link
Contributor

@Fogapod if you rebase your PR on the latest main, the CI errors should be resolved.

@vagenas vagenas merged commit f10b228 into DS4SD:main Jan 21, 2025
7 checks passed
@Fogapod Fogapod deleted the chunk-type-hint branch January 21, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants