Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke ping6 #144

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Smoke ping6 #144

merged 2 commits into from
Jan 28, 2025

Conversation

ogournet
Copy link
Contributor

No description provided.

Copy link
Collaborator

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Olivier,

thanks for adding a test. The code looks good to me. Can you just add a short explanation of what was happening before your fix?

Calloc never fails, but here it would always fails.

Fixes: 71a80f6 ("ip6: add ping and traceroute command")
Signed-off-by: Olivier Gournet <[email protected]>
Add some ipv6 pings issued from grcli.

Signed-off-by: Olivier Gournet <[email protected]>
@rjarry rjarry merged commit 11fe09f into DPDK:main Jan 28, 2025
4 checks passed
@ogournet ogournet deleted the smoke-ping6 branch January 29, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants