ndp: fix icmp6 option parsing #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expecting that packet data is contiguous is wrong. Plus the current code is not safe against (forged?) truncated packets at the NDP protocol level. Rework existing helper and avoid pointer arithmetics. Fixes: fb72a4d ("ip6: implement dynamic node address discovery") Signed-off-by: David Marchand <[email protected]>
rjarry
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expecting that packet data is contiguous is wrong. Plus the current code is not safe against (forged?) truncated packets at the NDP protocol level.
Rework existing helper and avoid pointer arithmetics.
Fixes: fb72a4d ("ip6: implement dynamic node address discovery")