Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic DOV WFS layers #383

Merged
merged 19 commits into from
May 2, 2023
Merged

Add support for generic DOV WFS layers #383

merged 19 commits into from
May 2, 2023

Conversation

Roel
Copy link
Member

@Roel Roel commented Apr 25, 2023

  • I have read and followed the guidelines in the CONTRIBUTING document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR adds support for searching generic WFS layers from DOV. Next to the existing 'fixed' datatypes, this make all other WFS data we publish available in pydov too, allowing users to use them using the same search options they already know from the other datatypes.

To support this we are now also more relaxed about metadata being available: we will still use it when it's available, but will no longer raise errors when it's not. While all of our layers should have metadata available, most of them don't have a feature catalogue. We will now return 'None' in the description of get_fields() when this is missing.

This PR includes tests, updated documentation and a tutorial.

@Roel Roel added this to the 3.1.0 milestone Apr 25, 2023
@Roel
Copy link
Member Author

Roel commented Apr 25, 2023

@GuillaumeVandekerckhove can you take a look at this too?

Copy link
Contributor

@GuillaumeVandekerckhove GuillaumeVandekerckhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to update tutorial notebook.
Question how to fix typo in xml.

docs/notebooks/search_generic_wfs.ipynb Outdated Show resolved Hide resolved
</gmd:CI_Citation>
</gmd:citation>
<gmd:abstract>
<gco:CharacterString xmlns:gco="http://www.isotc211.org/2005/gco">Een DOV-opdracht wordt meestal gebruikt om gegevens van dezelfde herkomst te groeperen in een herkenbaar geheel, Deze opdrachten vormen een snelle toegang naar een specifieke (deel)dataset.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo
Where is this xml generated or what is the source of the xml?

update_file('types/generic/md_metadata.xml',
build_dov_url(
'geonetwork/srv/dut/csw'
'?Service=CSW&Request=GetRecordById&Version=2.0.2'
'&outputSchema=http://www.isotc211.org/2005/gmd'
'&elementSetName=full&id=8a07f330-3900-4086-89c0-'
'cebf940156e5'))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the XML representation of the metadata of the layer dov-pub:Opdrachten. It is downloaded from Geonetwork (web version is here), but Geonetwork harvests this from our Geoserver.

This needs to be updated in the Geoserver work environment and then the (metadata of the) layer dov-pub:Opdrachten needs to be republished.

Het doel waarvoor een opdracht uitgevoerd is kan sterk verschillen. Dit wordt gedocumenteerd aan de hand van de velden aard en origine. Aard van de opdracht geeft een indicatie van de thematiek waarbinnen de gegevens verzameld worden. Origine van de opdracht geeft een indicatie van de herkomst van het ontstaan van de gegevens binnen de opdracht.</gco:CharacterString>
</gmd:abstract>
<gmd:purpose>
<gco:CharacterString xmlns:gco="http://www.isotc211.org/2005/gco">Een DOV-opdracht wordt meestal gebruikt om gegevens van dezelfde herkomst te groeperen in een herkenbaar geheel, Deze opdrachten vormen een snelle toegang naar een specifieke (deel)dataset.</gco:CharacterString>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

<gmd:source>
<gmd:LI_Source>
<gmd:description>
<gco:CharacterString xmlns:gco="http://www.isotc211.org/2005/gco">Een DOV-opdracht wordt meestal gebruikt om gegevens van dezelfde herkomst te groeperen in een herkenbaar geheel, Deze opdrachten vormen een snelle toegang naar een specifieke (deel)dataset.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@Roel Roel merged commit 27c70ac into master May 2, 2023
@Roel Roel deleted the all-wfs-layers branch May 3, 2023 16:44
@Roel Roel mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants