-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chart challenge 2023 to vizlab homepage #36
Add chart challenge 2023 to vizlab homepage #36
Conversation
@@ -0,0 +1,412 @@ | |||
export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long term we should use a similar approach to these charts and the other data viz on the site. This way is good, just will get confusing to have 2 separate tracking files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe moving forward, using this approach so there's a json for each of the lanes on the portfolio (i.e. interactives, chart gallery)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I like that idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took a long time for one of the images to load when I clicked on it. Looking at the pipeline, it seems like we're serving up the full size images as thumbnails, is that right? Do all of the images load once any single image is clicked on?
Carousel navigation: I think some sort of side navigation is needed to show that there are more images in the carousel. You can see that by clicking the dots below, but it is pretty subtle. Something pointing to the right would help guide the user.
Placement: I think it's fine to put this at the top above the interactives, but it feels very separate from the chart gallery and as a user, I might not understand the distinction. What do you think about making this carousel a part of the chart gallery - like the chart challenge is a subset of the chart gallery?
Contents: To simplify the chart gallery and fit better together - what about including any of the past chart challenge charts here as well?
Agreed that something is up w/ how the images are loaded. I think the full-size images are being loaded as the thumbnails instead of the webp versions. I've created a new issue #37 to look into that in another PR
Oh good thought. I added the navigation controls:
I've moved it into the chart gallery, as a subsection:
We could do this - I think we'd want to modify the captions to something like '2023 contribution for ....'. Only thing is, I'm pretty sure there are no charts in the chart gallery from 2022, so right now it would just be adding these 5: |
This looks good to merge. We should add the 2022 charts into the chart gallery also, but that can happen later. I think it would also be great to adapt use the carousel in some other places - like for river conditions and flow tiles and snow tiles. |
Agreed! I'll add some issues now |
Changes made:
Add new section to the 'Visualizations' portion of the site that includes a carousel of the 2023 chart challenge charts. EDIT:
For now (for visual consistency) the carousel is placed inside an accordion. As we move away from the accordions we can change that (or we could drop now, would just need to style the 'Chart Challenge 2023 header' differently to match the accordion header settings (minus the triangle))It was bothering me to have such a short section in an accordion, so I took it out.Fullscreen:
Changes:
CC23_Carousel.vue
, based off the carousels in Snow-to-flowmain.js
, as in Snow-to-flowCC23_Carousel.vue
toPortfolioAccordions.vue
as an accordion item (for now)CC23_Carousel.vue
usingsrc/assets/content/CC23.js
, with entries for each chartCC23_Carousel.vue
using entry attributes and urls fromsrc/assets/content/CC23.js
Visualization.vue
Note:
Other small edits
viz-list.csv
to fix the duplicate key '' warningAbout.vue
Testing:
Before making this pull request, I:
I can confirm this has been checked on: