Mgs time bias #538
Mgs time bias #538
Conversation
| @@ -140,7 +140,7 @@ def test_custom_frame_chain_iak(self, from_spice): | |||
| target_frame_id.return_value = -800 | |||
| frame_chain = self.driver.frame_chain | |||
| assert len(frame_chain.nodes()) == 0 | |||
| from_spice.assert_called_with(center_ephemeris_time=2.4, ephemeris_times=[2.4], nadir=False, sensor_frame=14082360, target_frame=-800, exact_ck_times=True) | |||
| from_spice.assert_called_with(center_ephemeris_time=2.4, ephemeris_times=[2.4], nadir=False, sensor_frame=14082360, target_frame=-800, exact_ck_times=True, inst_time_bias=0) | |||
There was a problem hiding this comment.
Why is this only necessary on cassini drivers?
There was a problem hiding this comment.
Cassini has a special additional frame that is added to the end of the frame chain. It seems like that driver is the only thing testing the from_spice call.
I think that the NaifData class tests should have caught this as well, it's just hard to get all the checks.
|
Looks like this is already done! |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 17.03% 17.00% -0.03%
==========================================
Files 53 53
Lines 5824 5834 +10
==========================================
Hits 992 992
- Misses 4832 4842 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* Updated disclaimer for release * Handle MGS time bias for NAC and WAC * Re-enabled MGS drivers * Updated changelog
* Updated disclaimer for release * Handle MGS time bias for NAC and WAC * Re-enabled MGS drivers * Updated changelog
Address a time bias in the MGS NAC/WAC images resulting in poorly corresponding ephemeris data when compared to ISIS