Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hayabusa amica #521

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Hayabusa amica #521

merged 7 commits into from
Mar 20, 2023

Conversation

jrcain-usgs
Copy link
Contributor

@jrcain-usgs jrcain-usgs commented Feb 16, 2023

Added Hayabusa amica driver and assc. tests.
Sorted pck kernel first so it can be overridden by more specific kernels.
Checked for more than 1 ephemeris time in frame chain to avoid getting unnecessary exact_ck_times for Framers.

@jrcain-usgs jrcain-usgs marked this pull request as ready for review February 17, 2023 23:54
@codecov-commenter
Copy link

Codecov Report

Merging #521 (7d40eb0) into master (1775745) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   17.90%   17.52%   -0.39%     
==========================================
  Files          52       53       +1     
  Lines        5483     5605     +122     
==========================================
  Hits          982      982              
- Misses       4501     4623     +122     
Impacted Files Coverage Δ
ale/drivers/hayabusa_drivers.py 0.00% <0.00%> (ø)
ale/transformation.py 0.00% <0.00%> (ø)
ale/util.py 0.00% <0.00%> (ø)
ale/drivers/mgs_drivers.py 0.00% <0.00%> (ø)
ale/base/type_distortion.py 0.00% <0.00%> (ø)
ale/drivers/chandrayaan_drivers.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlaura jlaura changed the base branch from master to main February 23, 2023 17:00
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tests verified locally as CI not running

@acpaquette acpaquette merged commit dfdecd9 into DOI-USGS:main Mar 20, 2023
jrcain-usgs added a commit to jrcain-usgs/ale that referenced this pull request May 19, 2023
* add hayabusa drivers (part 1)

* amica tests (load test fails), partial NIRS driver

* moved Hayabusa NIRS driver to its own branch

* sorted pck kernels first, checked for >1 eph times

* corrected new horizons radii in tests

* IsisLable mixin handles clock times with qunatities

* Removed spacecraft_clock tests

---------

Co-authored-by: acpaquette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants