Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocam warnings added #4217

Merged
merged 5 commits into from
Dec 22, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ update the Unreleased link so that it compares against the latest release tag.

### Added

- Added warning to ocams2isis about the model being out of date. [#4200](https://github.com/USGS-Astrogeology/ISIS3/issues/4200)
- Added documentation to lronaccal and lrowaccal to describe why there are negative DNs in I/F calibrated images. [#3860](https://github.com/USGS-Astrogeology/ISIS3/issues/3860)
- Update qview MeasureTool to add an option to calculate distances using RA/DEC and update qview to show DEC/RA rather than LAT/LON in lower-right corner [#3371](https://github.com/USGS-Astrogeology/ISIS3/issues/3371)

Expand Down
3 changes: 3 additions & 0 deletions isis/src/osirisrex/apps/ocams2isis/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ void IsisMain() {

UserInterface &ui = Application::GetUserInterface();

QString error_message = "WARNING: This camera model is out of date. See ocam2isis documentation for details.";
std::cerr << error_message << std::endl;

ProcessImportFits importFits;

importFits.setFitsFile(FileName(ui.GetFileName("FROM")));
Expand Down
12 changes: 11 additions & 1 deletion isis/src/osirisrex/apps/ocams2isis/ocams2isis.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
This program will import FITS (Flexible Image Transport System) formatted files from the
OSIRIS-REx MapCam, SamCam, and PolyCam instruments into the ISIS format.
</p>
<p>
Current known errors from OSIRIS-REx Image Processing Working Group work that have been fixed in their version but not in the public version:
<ul>
<li>Focal position dependent distortion for the PolyCam model is not implemented</li>
<li>The current distortion is out of date, software changes are needed to use the OpenCV based distortion in the latest IKs</li>
<li>The Struct SPK is not being used which accounts for the positions of the instruments relative to the center of the spacecraft. From the struct kernel docs this will result in an error of about a meter.</li>
<li>Only specific sites have DSKs available. Software changes are required to load multiple DSKs at the same time. It is recommended that you only work within the extents of the DSK you are using. Use the dskbrief utility to view the lat/lon extents of your DSK file.</li>
</ul>
Based on these issues, it is recommended that users don't attempt to do sub-meter or color processing with this version of the software.
</p>
</description>

<history>
Expand All @@ -29,7 +39,7 @@
Updated to translate PolyCam kernels separately from other cameras. Fixes #5128
</change>
<change name="Jeannie Backer" date="2017-08-25">
Reverted code to only deal with a single kernels translation file for all instruments. Added
Reverted code to only deal with a single kernels translation file for all instruments. Added
PolyCamFocusPositionNaifId keyoword to kernels translation file. References #5127
</change>
</history>
Expand Down