-
Notifications
You must be signed in to change notification settings - Fork 40
Shrinks logo on mobile, padding adjs, renames "eiti" logo style to "nrrd" #2442
Conversation
_sass/blocks/_header.scss
Outdated
@@ -47,7 +47,7 @@ header, | |||
|
|||
.header-left { | |||
@include span-columns(6); | |||
margin-bottom: $base-padding; | |||
margin-bottom: $base-padding-base; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 3 spaces
_sass/blocks/_header.scss
Outdated
@@ -47,7 +47,7 @@ header, | |||
|
|||
.header-left { | |||
@include span-columns(6); | |||
margin-bottom: $base-padding; | |||
margin-bottom: $base-padding-base; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 3 spaces
_sass/blocks/_header.scss
Outdated
@include span-columns(6); | ||
margin-bottom: $base-padding-base; | ||
|
||
@include respond-to(medium-up) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 1 spaces
_sass/blocks/_header.scss
Outdated
margin-top: 2rem; | ||
} | ||
@include span-columns(6); | ||
margin-bottom: $base-padding-base; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 1 spaces
_sass/blocks/_header.scss
Outdated
margin-bottom: 0; | ||
margin-top: 2rem; | ||
} | ||
@include span-columns(6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 1 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those Hound errors have to be fixed, but everything else looks good here. Happy to see variables being used for spacing rather then random values.
_sass/blocks/_header.scss
Outdated
|
||
@include respond-to(medium-up) { | ||
@include span-columns(3); | ||
@include respond-to(medium-up) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 1 spaces
_sass/blocks/_header.scss
Outdated
@include span-columns(6); | ||
margin-bottom: $base-padding; | ||
@include span-columns(6); | ||
margin-bottom: $base-padding-base; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
_sass/blocks/_header.scss
Outdated
|
||
@include respond-to(medium-up) { | ||
width: auto; | ||
} | ||
} | ||
|
||
.header-left { | ||
@include span-columns(6); | ||
margin-bottom: $base-padding; | ||
@include span-columns(6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 1 spaces
_sass/blocks/_header.scss
Outdated
|
||
@include respond-to(medium-up) { | ||
@include respond-to(medium-up) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line should be indented 2 spaces, but was indented 4 spaces
@msecret i give up. #help |
Fixes issue with logo hitting hamburger menu on small mobile devices.
😎 PREVIEW
A couple of additional minor tweaks (eg vertical alignment) can be made later, eg when we implement a revised search (#2403), and if we replace icons such as the hamburger with svg files (#2284)