Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Shrinks logo on mobile, padding adjs, renames "eiti" logo style to "nrrd" #2442

Merged
merged 5 commits into from
Nov 15, 2017

Conversation

ericronne
Copy link
Contributor

Fixes issue with logo hitting hamburger menu on small mobile devices.

😎 PREVIEW

A couple of additional minor tweaks (eg vertical alignment) can be made later, eg when we implement a revised search (#2403), and if we replace icons such as the hamburger with svg files (#2284)

@@ -47,7 +47,7 @@ header,

.header-left {
@include span-columns(6);
margin-bottom: $base-padding;
margin-bottom: $base-padding-base;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 3 spaces

@@ -47,7 +47,7 @@ header,

.header-left {
@include span-columns(6);
margin-bottom: $base-padding;
margin-bottom: $base-padding-base;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 3 spaces

@include span-columns(6);
margin-bottom: $base-padding-base;

@include respond-to(medium-up) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 1 spaces

margin-top: 2rem;
}
@include span-columns(6);
margin-bottom: $base-padding-base;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 1 spaces

margin-bottom: 0;
margin-top: 2rem;
}
@include span-columns(6);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 1 spaces

Copy link
Contributor

@msecret msecret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those Hound errors have to be fixed, but everything else looks good here. Happy to see variables being used for spacing rather then random values.


@include respond-to(medium-up) {
@include span-columns(3);
@include respond-to(medium-up) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 1 spaces

@include span-columns(6);
margin-bottom: $base-padding;
@include span-columns(6);
margin-bottom: $base-padding-base;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces


@include respond-to(medium-up) {
width: auto;
}
}

.header-left {
@include span-columns(6);
margin-bottom: $base-padding;
@include span-columns(6);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 1 spaces


@include respond-to(medium-up) {
@include respond-to(medium-up) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces

@ericronne
Copy link
Contributor Author

@msecret i give up. #help

@msecret msecret merged commit d0e4a50 into dev Nov 15, 2017
@msecret msecret deleted the Logo-responsive-adjustments branch November 15, 2017 17:57
@msecret msecret mentioned this pull request Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants