This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Global header and footnote changes, etc #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Global header styles tweaked for improved hierarchy - Footnotes shrunk - How it works landing narrowed - About landing header style simplified - Added $standard-padding-standard variable (1rem)
added 2 commits
April 25, 2017 13:01
houndci-bot
reviewed
Apr 27, 2017
_sass/components/_ribbon.scss
Outdated
| @@ -417,7 +373,8 @@ svg { | |||
| } | |||
|
|
|||
| .ribbon .ribbon-card { | |||
| padding-top: $base-padding-large; | |||
| padding-top: $base-padding-extra; | |||
There was a problem hiding this comment.
Properties should be ordered margin-top, padding-top
ericronne
changed the title
gemfarmer
suggested changes
Apr 27, 2017
| font-weight: $weight-light; | ||
| line-height: 2.5rem; // 40px | ||
| // light 30/38.4 | ||
| color: $gray-darkest; |
There was a problem hiding this comment.
We're changing the color for h2s globally? Does that work on all of the other pages?
| <div class="ribbon-card-top ribbon-card-top-text"> | ||
| <h2 class="ribbon-card-top-text-header ribbon-card-top-text-header-padded">The U.S. ranks at or near the top worldwide in the production of many natural resources.</h2> | ||
| <h2 class="ribbon-card-top-text-header">The U.S. ranks at or near the top worldwide in the production of many natural resources.</h2> |
| @@ -15,11 +15,11 @@ <h1 id="title">Case studies</h1> | |||
| </figure> | |||
| </div> | |||
| <div class="container-right-4 ribbon-card-column ribbon-card state_pages-ribbon-card ribbon-card-no-margin"> | |||
| <figure class="ribbon-card-top ribbon-card-case_studies"> | |||
| <div class="ribbon-card-top"> | |||
| @@ -6,14 +6,15 @@ | |||
|
|
|||
| p { | |||
| @include heading('para-xl'); | |||
| margin-top: 2.25rem; | |||
There was a problem hiding this comment.
Could this be something in variables? $standard-padding-large? 1/875rem
_sass/components/_footnotes.scss
Outdated
| @@ -31,19 +31,19 @@ body { | |||
| ol { | |||
| @include heading('para-sm'); | |||
|
|
|||
| font-weight: 200; | |||
| font-weight: 400; | |||
_sass/components/_footnotes.scss
Outdated
|
|
||
| &:target { | ||
| background-color: $mid-blue; | ||
| } | ||
| } | ||
|
|
||
| p { | ||
| padding-bottom: $base-padding-lite; | ||
| @include heading('para-med'); |
There was a problem hiding this comment.
I think this is @include heading('para-md');
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
free preview!
Some changes: