Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Staging --> master v2.1.8 #2230

Merged
merged 163 commits into from
Mar 15, 2017
Merged

Staging --> master v2.1.8 #2230

merged 163 commits into from
Mar 15, 2017

Conversation

meiqimichelle
Copy link
Contributor

This release makes the following changes:

coreycaitlin and others added 26 commits March 2, 2017 18:13
Update federal reforms content
Use eslint instead of jshint
changed top of renewables bg gradient to new gray
Update stickies to support browsers that support position:sticky
Add 2016 disbursements, update data transforms
New card images woo, also changed a link and emboldened small headers
[WIP] Re-style withheld list
-webkit-font-smoothing: antialiased;
padding-top: 0.7em;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background-color, color, -webkit-font-smoothing, padding-bottom, padding-left, padding-right, padding-top

@@ -116,7 +114,7 @@ $ab-border-thick: 4px;
}

td {
padding-left: 0;
padding: 20px 10px 0 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorthands of length 4 are not allowed. Value was 20px 10px 0 0



it('properly sums up "All" disbursements by fund', function() {
xit('properly sums up "All" disbursements by fund', function() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'xit' is not defined no-undef

@@ -82,7 +82,7 @@ describe('disbursements', function() {
});
});

it("doesn't contain values that aren't in the pivot table", function(done) {
xit("doesn't contain values that aren't in the pivot table", function(done) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'xit' is not defined no-undef

require('./../pages/company-revenue.js');
})(window);
require('./../eiti.explore.js');
require('./../pages/company-revenue.js');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'require' is not defined no-undef

(function(exports) {
'use strict';

var CustomEvent = require('custom-event');
var topojson = require('topojson');
var queue = require('d3-queue');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'require' is not defined no-undef

(function(exports) {
'use strict';

var CustomEvent = require('custom-event');
var topojson = require('topojson');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'require' is not defined no-undef

@@ -100,7 +106,9 @@
}
});

var extent = d3.extent(data, function(d) { return d.y; });
var extent = d3.extent(data, function(d) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'd3' is not defined no-undef

@@ -86,7 +90,9 @@

var xrange = this.xrange;
if (!xrange) {
xrange = d3.extent(data, function(d) { return +d.x; });
xrange = d3.extent(data, function(d) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'd3' is not defined no-undef

@@ -163,7 +167,9 @@
return xdomain.indexOf(d.x) > -1;
});

var extent = d3.extent(data, function(d) { return d.y; });
var extent = d3.extent(data, function(d) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'd3' is not defined no-undef

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants