TAO IDL: Interface Annotations #967
Conversation
Used bison 3.4, but the generated code doesn't look very different. Also Updated annotations.md with: - a list of what can be annotated - how to extend annotation support in the future - other minor fixes
iguessthislldo
changed the title
iguessthislldo
changed the title
|
So the fuzz has a check for
What kind of conflict was it and will it still happen? Regardless this sounds like Doxygen was/is being configured incorrectly to me. |
| @@ -345,11 +375,11 @@ these lines would also need to be added: | |||
| if (document) | |||
| { | |||
| const char *comment = | |||
| AST_Annotation_Member::narrow_from_decl ((*document)["comment"])-> | |||
| dynamic_cast<AST_Annotation_Member *> ((*document)["comment"])-> | |||
There was a problem hiding this comment.
Out of curiosity, why do you use dynamic_cast instead of narrow_from_decl?
There was a problem hiding this comment.
narrow_from_decl is defined in include/idl_narrow.h where it's just a dyanmic_cast. It's a left over from an old narrowing system from the original pre C++98 compiler when they didn't apparently have dynamic_cast.
There was a problem hiding this comment.
I guess I should also say that we should prefer standard C++ over pre-standard stuff whenever it's possible to.
There was a problem hiding this comment.
Maybe make a todo to make this a global change in TAO_IDL to simplify the code overall
Co-Authored-By: Adam Mitz <[email protected]>
|
BE_post_init() in TAO/tests/IDLv4/annotations/be_init.cpp is quite long. Maybe split it in helper functions? |
|
Sure, it's something I thought about doing when I originally created it, but never quite go around to doing. |
…/ACE_TAO into igtd/iterface_annotations
Updated
tao_idlto support annotations on interfaces, operations, and attributes.Also Updated annotations.md With:
TODO