fixed fstat on win32 (support 64 bit file sizes)

[esohns]

No description provided.

[jwillemsen]

See also #1074

[esohns]

Note: the ACE_OS::stat function (OS_NS_sys_stat.inl lines 221) has the same issue for the Windows CE case (ACE_HAS_WINCE). Not sure whether Windows CE ever supported 64 bits though... In that case, it might make more sense to use the alternate approach of #1074 and use the ACE macro (ACE_MAKE_QWORD) instead of my solution (ULARGE_INTEGER comes from the current winnt.h; I do not know when it was first introduced).

ACE_COMBINE_PARTS could be used instead also, but note it has a "signed" high part, while nFileSizeHigh and nFileSizeLow members of BY_HANDLE_FILE_INFORMATION are both unsigned DWORDs [Note: (oddly enough,) ACE_OFF_T is "signed" as well...why ?]. Also, it refers to winnt.h (for LARGE_INTEGER), which may not be available on Windows CE systems (this claim needs confirmation). IMHO using ACE_MAKE_QWORD seems to be the more generic approach (only bit shifts and logic operators).

So I also suggest to first move the macro ACE_MAKE_QWORD functionality out of OS_NS_time.h to a more "global" header (Global_Macros.h, somewhere around ACE_NOOP, or OS_NS_macros.h ?), as mitza-oci suggested, so it can be used everywhere; and someone could then update all usages of ACE_COMBINE_PARTS/ [U]LARGE_INTEGER to move to ACE_MAKE_QWORD later on.

As jwillemsen already mentioned, there probably should exist some test-case for this (for both 64 bit and 32 bit platforms, using ACE_MAKE_QWORD ?/ACE_COMBINE_PARTS ?/...?).

FWIW I tested this solution locally, and it works OK with files larger than 4GB (64 bit Windows 11 VS2022, ACE compiled with _FILE_OFFSET_BITS == 64). However, I cannot test the "true" 64 bit corner cases (i.e. between signed/unsigned ACE_OFF_T) due to lack of resources, and I am not going back to 32 bits (unless someone pays me...).

[coderabbitai]

Warning

Rate limit exceeded

@jwillemsen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 408bd95 and b3a73ed.

📒 Files selected for processing (1)

• ACE/ace/OS_NS_sys_stat.inl (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jwillemsen]

Is this the same as #2254?

[esohns]

yes, more or less. See comment about WinCE support

[jwillemsen]

Windows CE support has been removed on master some time ago

[esohns]

what about using ACE_MAKE_QWORD or ACE_COMBINE_PARTS instead of using ULARGE_INTEGER (seems to be windows nt-specific ?)