Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional role_name parameter #35

Merged

Conversation

OfirYaron
Copy link
Contributor

When using two clusters with the same name on two different regions under the same account, the load balancer controller ingress role is shared and being updated from both ends causing issues.

the solution was fairly simple - add an override attribute to the module: 'role_name'

  • the fix is backward compatible
  • if omitted the same-already-active naming convention will be used
  • I've Hoisted the role name into a local with a condition and used that local in two placed it was required (easier to maintain)

@OfirYaron OfirYaron mentioned this pull request Sep 21, 2023
1 task
@brunodasilvalenga
Copy link
Contributor

Hey @OfirYaron thanks for opening the PR. I will be reviewing it and get back to you!

Copy link
Contributor

@brunodasilvalenga brunodasilvalenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunodasilvalenga brunodasilvalenga merged commit f29ab0d into DNXLabs:master Sep 27, 2023
@brunodasilvalenga
Copy link
Contributor

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants