fix(multiple): le bouton retour apparait tout le temps #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naorid
force-pushed
the
feat/UNJ1S-1789-bouton-retour-apparait-tout-le-temps
branch
3 times, most recently
from
5e61b7e to
d3796b7
Compare
Naorid
force-pushed
the
feat/UNJ1S-1789-bouton-retour-apparait-tout-le-temps
branch
from
d3796b7 to
3bbcc61
Compare
gmoocto
reviewed
Nov 21, 2023
| @@ -25,7 +25,7 @@ export function ErrorLayout(props: React.PropsWithChildren<ErrorLayoutProps>) { | |||
| <div> | |||
| {children} | |||
| <div className={styles.buttonWrapper}> | |||
| <BackButton aria-label="Retourner à la page précédente" label="Retourner à la page précédente" appearance="primary" className={styles.backButton}/> | |||
| <BackButton alwaysDisplay={true} aria-label="Retourner à la page précédente" label="Retourner à la page précédente" appearance="primary" className={styles.backButton}/> | |||
There was a problem hiding this comment.
À la lecture du code, j'ai un peu de mal à voir pourquoi on a besoin d'un alwaysDisplay 🤔
There was a problem hiding this comment.
Pour la page d'erreur je trouvais ca pertinent d'avoir tout le temps le bouton 🤷
gmoocto
requested changes
Nov 22, 2023
Naorid
force-pushed
the
feat/UNJ1S-1789-bouton-retour-apparait-tout-le-temps
branch
from
636b227 to
2e6aaae
Compare
gmoocto
approved these changes
Nov 24, 2023
Naorid
deleted the
feat/UNJ1S-1789-bouton-retour-apparait-tout-le-temps
branch
Naorid
added a commit
that referenced
this pull request
Nov 27, 2023
* fix(multiple): le bouton retour apparait tout le temps * fix: retour review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.