Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emplois): passage ssr + scroll restoration #2273

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

Naorid
Copy link
Contributor

@Naorid Naorid commented Nov 8, 2023

No description provided.

@Naorid Naorid changed the title wip feat(emplois): passage ssr + scroll restoration Nov 9, 2023
@Naorid Naorid force-pushed the feat/UNJ1S-1732-POC-comportement-bouton-retour branch from a44d026 to fbef50b Compare November 13, 2023 09:42
@Naorid Naorid force-pushed the feat/UNJ1S-1732-POC-comportement-bouton-retour branch from 4f88d21 to bf3b9a7 Compare November 15, 2023 10:27
@Naorid Naorid force-pushed the feat/UNJ1S-1732-POC-comportement-bouton-retour branch 4 times, most recently from ba2b2f0 to 035cdca Compare November 20, 2023 14:49
@Naorid Naorid force-pushed the feat/UNJ1S-1732-POC-comportement-bouton-retour branch from 035cdca to 3b4e9f2 Compare November 20, 2023 15:25
@Naorid Naorid marked this pull request as ready for review November 20, 2023 16:11
@@ -23,6 +23,7 @@ API_ONISEP_ACCOUNT_PASSWORD=password-bidon
API_ONISEP_APPLICATION_ID=123456789
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quand je vois ce que ça implique sur notre code, je me dis qu'il faudrait reconsidérer le choix de ce bouton retour ....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, après ça reste valable sans le bouton retour, pour un utilisateur qui utilise la fonctionnalités "précédent" de son navigateur

Copy link
Contributor

@gmoocto gmoocto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça paaaaaasse

@Naorid Naorid force-pushed the feat/UNJ1S-1732-POC-comportement-bouton-retour branch from 48b6fd8 to fdc9e09 Compare November 23, 2023 16:16
@Naorid Naorid merged commit 35a2135 into main Nov 24, 2023
6 checks passed
@Naorid Naorid deleted the feat/UNJ1S-1732-POC-comportement-bouton-retour branch November 24, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants