Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP error #77

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Sep 22, 2020

We're seeing a semi-consistent error during install, where retrying works. This is an adjustment to the error handling to allow this error to trigger the retry logic instead of failing immediately.

Error details
> Starting installation...
> Exception caught at: 9/11/2020 6:45:55 PM.
> System.Net.Http.HttpRequestException | An error occurred while sending the request.
>    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
>    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
>    at DeployClient.API.d__3.MoveNext() in C:\DNNDev\CantarusCore\PolyDeploy\DeployClient\API.cs:line 62
> --- End of stack trace from previous location where exception was thrown ---
>    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
>    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
>    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
>    at DeployClient.Program.d__2.MoveNext() in C:\DNNDev\CantarusCore\PolyDeploy\DeployClient\Program.cs:line 148
> System.Net.WebException | Unable to connect to the remote server
>    at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
>    at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar)
> System.Net.Sockets.SocketException | A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond 12.147.61.210:443
>    at System.Net.Sockets.Socket.InternalEndConnect(IAsyncResult asyncResult)
>    at System.Net.Sockets.Socket.EndConnect(IAsyncResult asyncResult)
>    at System.Net.ServicePoint.ConnectSocketInternal(Boolean connectFailure, Socket s4, Socket s6, Socket& socket, IPAddress& address, ConnectSocketState state, IAsyncResult asyncResult, Exception& exception)

@bdukes
Copy link
Contributor Author

bdukes commented Oct 21, 2020

I can confirm that integrating this change has resolved this issue for us.

@mitchelsellers mitchelsellers merged commit 3426212 into DNNCommunity:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants