Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible to add contributor without a name - even though it appears as compulsory field #2983

Closed
magdalenadrafiova opened this issue Jul 28, 2021 · 11 comments
Closed

possible to add contributor without a name - even though it appears as compulsory field #2983

magdalenadrafiova opened this issue Jul 28, 2021 · 11 comments
Assignees
@johnpinto1
Labels
bug effort-small less than 1/2 day of dev time

Comments

@magdalenadrafiova
Copy link

magdalenadrafiova commented Jul 28, 2021 •
edited
Loading

@raycarrick @briri
I am testing on DMPonline-dev the latest 3.3 release. Not sure
The contributor name appears as compulsory field but when I left it empty it was alright to save:
Screenshot 2021-07-28 at 14 53 06

See contributor without a name:
Screenshot 2021-07-28 at 14 53 42
@briri
Copy link
Contributor

briri commented Jul 28, 2021 •
edited
Loading

The logic in the code requires one or the other (name or email). Should we actually require both or is one more important?

I don't necessarily think it should dictate how we collect data in the UI, but the RDA Common Standard requires the Name, a role designation and the ORCID (or some identifier) be present.

Whoever addresses this ticket should also remove the phone number per #2941

@mariapraetzellis mariapraetzellis added the effort-small less than 1/2 day of dev time label Aug 4, 2021
@johnpinto1 johnpinto1 self-assigned this Nov 4, 2021
@johnpinto1 johnpinto1 mentioned this issue Nov 4, 2021
Closed
@johnpinto1
Copy link
Contributor

Will look at #2941 next. Have a PR see above.

johnpinto1 pushed a commit that referenced this issue Nov 4, 2021
Issue#dcc2983 - Fix for preventing adding a Contributor via Contributor
26b4976 
page if both Name and Email are not present.

Fixes DCC bug #2983

Changes:
  - Changes in Contributor model:
       - Renamed validation method name_or_email_presence() -> name_and_email_presence()
       - Updated conditions in name_and_email_presence() method to return errors if Name or Email missing.
  - Updated tests in spec/models/contributor_spec.rb and spec/services/api/v1/contextual_error_service_spec.rb to reflect change in
Contributor model.
@johnpinto1 johnpinto1 mentioned this issue Nov 23, 2021
Merged
johnpinto1 pushed a commit that referenced this issue Nov 24, 2021
Issue#dcc2983 - Fix for preventing adding a Contributor via Contributor
db783fc 
form for Plan based on whether email and/or name are required.

Fix for DCC bug #2983

Changes:
 - Added two new properties to config/initializers/_dmproadmap.rb
   (both devault to false):
   config.x.application.require_contributor_name = false
   config.x.application.require_contributor_email = false
 -In Contributor model the private method name_or_email_presence()
  has been updated to take account of the above mentioned property
settings.
raycarrick-ed pushed a commit that referenced this issue Feb 2, 2022
@raycarrick-ed
Issue#dcc2983 - Fix for preventing adding a Contributor via Contributor
35fa595 
form for Plan based on whether email and/or name are required.

Fix for DCC bug #2983

Changes:
 - Added two new properties to config/initializers/_dmproadmap.rb
   (both devault to false):
   config.x.application.require_contributor_name = false
   config.x.application.require_contributor_email = false
 -In Contributor model the private method name_or_email_presence()
  has been updated to take account of the above mentioned property
settings.
@magdalenadrafiova
Copy link
Author

@johnpinto1 both still appears as compulsory fields on dev follow up with @dsisu once fixed so she can re-test and close
Screenshot 2022-03-01 at 14 54 45

@johnpinto1
Copy link
Contributor

The view is displaying wrong info. The code saves either name or email, but view shows incorrectly that both name and email are required.

johnpinto1 pushed a commit that referenced this issue Mar 4, 2022
Issue #2983 - Removed wrongly displayed required * for name and email
cb52da1 
fields on Contributor edit page.

Fix for issue #2983

Changes:
 - Removed aria: {required: true} from input tags for name and email.
@johnpinto1 johnpinto1 mentioned this issue Mar 4, 2022
Merged
@johnpinto1
Copy link
Contributor

Trivial fix done and PR created #3120
Selection_058

raycarrick-ed added a commit that referenced this issue Mar 4, 2022
@raycarrick-ed
Merge pull request #3120 from DMPRoadmap/bug_2983_contributor_page_sh…
049500f 
…owing_both_email_and_name_required_wrongly

Issue #2983 - Removed wrongly displayed required * for name and email
@pherterich
Copy link

Just catching up with things as part of trying to understand what the latest release covered: how is it obvious to a user in this new version that either name or email needs to be provided? Do we provide a meaningful error message if it isn't? Should we add a sentence saying that one of the two fields needs to be filled?

@raycarrick-ed
Copy link
Contributor

raycarrick-ed commented Mar 8, 2022 •
edited
Loading

This is a good point. @johnpinto1 how easy would it be to add a message to that effect? Fill in at least one of these fields?

@johnpinto1
Copy link
Contributor

@raycarrick-ed & @pherterich It should be trivial. Famous last words. Its just adding an text.

@pherterich
Copy link

"Please provide either Name or Email in addition to the fields indicated as mandatory using *"

Other suggestions on how to phrase this @dsisu @mariapraetzellis ?

@dsisu
Copy link

dsisu commented Mar 9, 2022

If the logic makes this easy to implement, I would say make both name and email address fields mandatory (and marked as such).

From the users' perspective, as readers, it looks much better if all contributors are named. The email address can be very different from the name and give no obvious indication who the contributor is.

From the user's perspective as the form-filler (the author of the plan), it's not a lot of information to ask of them. They must have spoken to their contributors so they will probably have their name and email address close to hand.

If we don't make both fields mandatory, then we Patricia's suggested wording is fine.

@johnpinto1
Copy link
Contributor

@dsisu CDL requires either name and email address fields , so it would be better to not require both mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnpinto1 johnpinto1

Labels
bug effort-small less than 1/2 day of dev time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@briri @dsisu @pherterich @johnpinto1 @raycarrick-ed @mariapraetzellis @magdalenadrafiova