Annotation update + use of defaultComponentName #214
Conversation
…anceName=false for Undirected.Topology.Connect... , 3) set defaultComponentName='splitter/junction' for SplitterT1/T2, junctionT1/T2 (and so on), 4) fixed small issue for DnymaicPressureInflow/Outflow/Nozzle concerning display
| @@ -1,7 +1,7 @@ | |||
| within ThermofluidStream.Undirected.Topology; | |||
| model ConnectForeFore "Connects two fore ports" | |||
|
|
|||
| extends ThermofluidStream.Utilities.DropOfCommonsPlus; | |||
| extends ThermofluidStream.Utilities.DropOfCommonsPlus(displayInstanceName=false); | |||
There was a problem hiding this comment.
I suggested to change the default value to false, because i had the feeling that ConnectForeFore is one of the last models where user would want to display the instance name.
Actually currently displayInstanceName=false for every example in the TFS. We might first consider setting displayInstanceName=true for at least a few important components in the TFS examples (like source/sink, heat exchangers, compressors).
There was a problem hiding this comment.
I suggested to change the default value to false, because i had the feeling that ConnectForeFore is ...
As is for ConnectForeOutlet & Co. as well.
We might first consider setting displayInstanceName=true for at least a few important components ...
This is in fact a subjective choice. Hope this will be helpful to users.
iconTransformation = ...iftransformation = ...is sufficientdefaultComponentName='splitter/junction'forTopology.SplitterT1, Topology.JunctionT1, (etc.)displayInstanceName=falseforThermofluidStream.Undirected.Topology.ConnectForeFore(etc.)