Fix pressure loss functions #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p::Processes
tobolar
approved these changes
Sep 28, 2023
ThermofluidStream/Processes/Internal/FlowResistance/laminarTurbulentPressureLossHaaland.mo
Outdated
Show resolved
Hide resolved
Co-authored-by: tobolar <[email protected]>
…ThermofluidStream into fixHaalandPressureLoss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Processes.Internal.FlowResistance.laminarTurbulentPressureLossHaaland, therelative_roughnesswas calculated before the pipe roughnesskswas defined. This caused an error in OpenModelica and hence it was moved to the algorithm section.Furthermore, all units for Reynolds numbers were updated with
Units.SI.ReynoldsNumberand variables without unit were given a unit.