Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong types #1309
base: main
Are you sure you want to change the base?
Strong types #1309
Changes from 17 commits
e2a6cd7
8ca1ae7
102da46
c1d0ebc
adf10fd
d241eee
6129d1a
32f7b0b
1e33703
7b0460f
8565b54
ed7442f
9214757
2a27f9e
39a357f
f0783a1
eb4af4b
9b33975
240b4f6
0029923
f7f8fe3
a0257b6
606a29b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we combine this with
src/t8_schemes/t8_crtp.hxx
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaught about it and had a short look into it. But this struct has an additional template argument than your implementation and I think that this is a detail that matters.