Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a screen before the race #96

Merged
merged 5 commits into from
May 29, 2022
Merged

adding a screen before the race #96

merged 5 commits into from
May 29, 2022

Conversation

Quinstedt
Copy link
Contributor

@Quinstedt Quinstedt commented May 28, 2022

Added a screen before the race, showing the finish line so that the user knows what they need to find.

Close related issue : #97

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Code change tested manually if not covered by automated tests
  • Pull request linked to one or more issues/stories
  • Acceptance criteria of the linked stories satisfied
  • Code change comprehended by those who approved it
  • State of target branch maintained or improved after the code change
  • Go to MainActivityTest in the Android App and uncommit @test
    Run test manually. Add a picture of the test result in the comments.
    Comment @test again to avoid future problems with the CI

@Quinstedt Quinstedt added the enhancement New feature or request label May 28, 2022
@Quinstedt Quinstedt added this to the Advance android application milestone May 28, 2022
@Quinstedt Quinstedt self-assigned this May 28, 2022
@Quinstedt Quinstedt linked an issue May 28, 2022 that may be closed by this pull request
@Quinstedt Quinstedt requested review from Dreia and faisal1201 May 28, 2022 20:48
Copy link
Contributor

@faisal1201 faisal1201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this update, the player can have an idea of what the finish line looks like and what they are looking for. And some bugs have been fixed. Approval granted !

@faisal1201
Copy link
Contributor

faisal1201 commented May 29, 2022

Test passing!

image

@faisal1201 faisal1201 merged commit 59da1fb into master May 29, 2022
@faisal1201 faisal1201 deleted the improvingRaceMode branch May 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an activity before the raceStart
2 participants