How to play Instructions and button Animation #88

faisal1201 · 2022-05-26T02:37:40Z

This pull request has commits related to instructions of the game. A user will be able to go through this and become familiar with what the game offers and how the controls work. So, that the player isn't lost while playing the game.
Animations for buttons also added
Recommended device to test : Pixel 3 XL API 31

Related Issue: closes #40 #89

☑️ Definition of Done checklist

Meaningful title and valuable description in pull request
Code change tested manually if not covered by automated tests
Pull request linked to one or more issues/stories
Acceptance criteria of the linked stories satisfied
Code change comprehended by those who approved it
State of target branch maintained or improved after the code change
Go to MainActivityTest in the Android App and uncommit @test
Run test manually. Add a picture of the test result in the comments.
Comment @test again to avoid future problems with the CI

Your changes needs to be commited if you want to change branch and avoid losing the changes

# Conflicts: # Android/islandRush/app/src/androidTest/java/com/quinstedt/islandRush/LeaderboardTest.kt # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/BrokerConnection.java # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/ControlPad.java # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/Joystick.java # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/MainActivity.java

…HOW_TO_PLAY_SCREEN � Conflicts: � Android/islandRush/app/src/androidTest/java/com/quinstedt/islandRush/LeaderboardTest.kt � Android/islandRush/app/src/main/AndroidManifest.xml � Android/islandRush/app/src/main/java/com/quinstedt/islandRush/BrokerConnection.java � Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/ControlPad.java � Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/MainActivity.java � Android/islandRush/app/src/main/java/com/quinstedt/islandRush/instructionScreens/controlsInstruction.java � Android/islandRush/app/src/main/java/com/quinstedt/islandRush/instructionScreens/gettingStarted.java � Android/islandRush/app/src/main/res/layout-land/activity_controls_instruction.xml � Android/islandRush/app/src/main/res/layout-land/activity_game_modes.xml � Android/islandRush/app/src/main/res/layout-land/activity_getting_started.xml � Android/islandRush/app/src/main/res/layout-land/activity_intro_splash_animation.xml � Android/islandRush/app/src/main/res/layout-land/activity_main.xml � Android/islandRush/app/src/main/res/layout/activity_controls_instruction.xml � Android/islandRush/app/src/main/res/layout/activity_game_modes.xml � Android/islandRush/app/src/main/res/layout/activity_getting_started.xml � Android/islandRush/app/src/main/res/layout/activity_main.xml � Android/islandRush/app/src/main/res/layout/activity_scoreboard.xml

The user of the app will now be able to get a Beginner's Guide on how to play the game,which includes the controls,what the game offers, and how to check the leaderboard. Related Issue : #40

Animation of buttonsUpon clicking buttons the buttons scale up .Other functionalities remains the same. Related Issue : #89

Quinstedt

Good job, But Could maybe change the color to white.

Black is a bit hard to read sometimes.

faisal1201 · 2022-05-27T09:25:54Z

Yes , I can change the color to white. Besides, what emulator are you using ? Seems like the whole layout can't be seen

text made white so that it's more visible to the player

faisal1201 · 2022-05-27T10:49:17Z

The text layout has been changed to white so that it appears more visible to the user.

…PLAY_SCREEN

faisal1201 · 2022-05-27T11:54:32Z

…and how to play buttons

Quinstedt · 2022-05-27T13:35:18Z

I fixing the constraint in all the activities. So wait until my next message to merge

Dreia · 2022-05-27T14:26:04Z

IslandRush can be played in two modes...
That's what I would put. Otherwise it's user is incorrect, should be its user

faisal1201 · 2022-05-27T14:48:38Z

The title can be changed np.

Quinstedt · 2022-05-27T20:43:50Z

The test are not passing because the title are not visible in the layout. Any particular reason why the recycle view is on top of the titles?

Quinstedt

The required changes have been made.

faisal1201 · 2022-05-27T20:51:52Z

What I have noticed is that the layout I made was for Pixel 3 XL API 31 and using another device which has a larger or smaller screen size changes the layout . Like the example you gave before, the recycle view is over the title.

Quinstedt · 2022-05-27T21:55:22Z

What I have noticed is that the layout I made was for Pixel 3 XL API 31 and using another device which has a larger or smaller screen size changes the layout . Like the example you gave before, the recycle view is over the title.

ok, I fixed the constrait so everything is passing now.

# Conflicts: # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/ControlChoice.java # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/ControlPad.java # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/Joystick.java

Redy to merge

…PLAY_SCREEN # Conflicts: # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/ControlChoice.java

Redy to merge

Quinstedt · 2022-05-28T10:07:37Z

all test passing manually

Quinstedt

Everything in this branch is ready to be merge, test are passing, contrainsts have been improve for most of the layouts.

faisal1201 and others added 8 commits May 22, 2022 23:09

Keep changes when switching branch

05cfd7c

Your changes needs to be commited if you want to change branch and avoid losing the changes

Include How to play Button

86a1bf1

Add how to play Button on activity_main

9b90be0

Finish Getting Started screen

c3d4f1a

Add instruction for controls and game modes

08458c7

Add "How to play ?" instructions

687362b

The user of the app will now be able to get a Beginner's Guide on how to play the game,which includes the controls,what the game offers, and how to check the leaderboard. Related Issue : #40

faisal1201 self-assigned this May 26, 2022

faisal1201 added #Sprint4 Issues to be worked on during Sprint 4 #Sprint3 User stories for 3 labels May 26, 2022

faisal1201 added this to the Advance android application milestone May 26, 2022

faisal1201 requested review from Quinstedt, itsdanesh and safayoussef May 26, 2022 02:38

Button Enhancement

cddaaea

Animation of buttonsUpon clicking buttons the buttons scale up .Other functionalities remains the same. Related Issue : #89

faisal1201 changed the title ~~How to play Instructions~~ How to play Instructions and button Animation May 26, 2022

Quinstedt requested changes May 27, 2022

View reviewed changes

Fix some Layouts for PIXEL 3 XL API 31

e17bb1a

text made white so that it's more visible to the player

faisal1201 and others added 5 commits May 27, 2022 13:02

Merge remote-tracking branch 'origin/master' into HOW_TO_PLAY_SCREEN

635207a

Merge branch 'master' into HOW_TO_PLAY_SCREEN

aac2b0f

just updating some methods name

9373dd6

Merge remote-tracking branch 'origin/HOW_TO_PLAY_SCREEN' into HOW_TO_…

6f7112a

…PLAY_SCREEN

Fix main Layout and add button enhancements to credits button

87d70b5

faisal1201 requested a review from Quinstedt May 27, 2022 12:04

Quinstedt and others added 2 commits May 27, 2022 15:09

Fixed the constraint for the main activity after the merge of credit …

b011cec

…and how to play buttons

Merge branch 'master' into HOW_TO_PLAY_SCREEN

fa5ab1d

Quinstedt and others added 3 commits May 27, 2022 17:43

Fixed the Constraint

5a89ebf

Game mode text view Title changed

bfc4838

Game mode text view Title changed

8d844b5

fixed the constraintof the scoreboard

c185295

Quinstedt previously approved these changes May 27, 2022

View reviewed changes

Quinstedt and others added 3 commits May 28, 2022 11:11

Merge remote-tracking branch 'origin/master' into HOW_TO_PLAY_SCREEN

88c07fa

Merge master to how to play screen

b1cbf88

faisal1201 dismissed Quinstedt’s stale review via b1cbf88 May 28, 2022 09:41

Quinstedt added 3 commits May 28, 2022 11:50

updated some comments, all test passing manually

ee2642d

Redy to merge

Merge remote-tracking branch 'origin/HOW_TO_PLAY_SCREEN' into HOW_TO_…

738d3fb

…PLAY_SCREEN # Conflicts: # Android/islandRush/app/src/main/java/com/quinstedt/islandRush/activityClasses/ControlChoice.java

updated some comments, all test passing manually

57b1227

Redy to merge

Quinstedt self-requested a review May 28, 2022 10:10

Quinstedt approved these changes May 28, 2022

View reviewed changes

Quinstedt merged commit f104389 into master May 28, 2022

Quinstedt deleted the HOW_TO_PLAY_SCREEN branch May 28, 2022 10:11

faisal1201 linked an issue May 28, 2022 that may be closed by this pull request

Button Enhancements #89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

How to play Instructions and button Animation #88

How to play Instructions and button Animation #88

faisal1201 commented May 26, 2022 •

edited by Quinstedt

Loading

Quinstedt left a comment

faisal1201 commented May 27, 2022

faisal1201 commented May 27, 2022

faisal1201 commented May 27, 2022

Quinstedt commented May 27, 2022

Dreia commented May 27, 2022

faisal1201 commented May 27, 2022

Quinstedt commented May 27, 2022

Quinstedt left a comment •

edited

Loading

faisal1201 commented May 27, 2022

Quinstedt commented May 27, 2022

Quinstedt commented May 28, 2022 •

edited

Loading

Quinstedt left a comment

How to play Instructions and button Animation #88

How to play Instructions and button Animation #88

Conversation

faisal1201 commented May 26, 2022 • edited by Quinstedt Loading

☑️ Definition of Done checklist

Quinstedt left a comment

Choose a reason for hiding this comment

faisal1201 commented May 27, 2022

faisal1201 commented May 27, 2022

faisal1201 commented May 27, 2022

Quinstedt commented May 27, 2022

Dreia commented May 27, 2022

faisal1201 commented May 27, 2022

Quinstedt commented May 27, 2022

Quinstedt left a comment • edited Loading

Choose a reason for hiding this comment

faisal1201 commented May 27, 2022

Quinstedt commented May 27, 2022

Quinstedt commented May 28, 2022 • edited Loading

Quinstedt left a comment

Choose a reason for hiding this comment

faisal1201 commented May 26, 2022 •

edited by Quinstedt

Loading

Quinstedt left a comment •

edited

Loading

Quinstedt commented May 28, 2022 •

edited

Loading