Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploration Mode and Race Mode #85

Merged
merged 11 commits into from
May 29, 2022
Merged

Exploration Mode and Race Mode #85

merged 11 commits into from
May 29, 2022

Conversation

Dreia
Copy link
Contributor

@Dreia Dreia commented May 25, 2022

This exploration mode will be uploaded as a separate mod with a few enhancements, being able to disappear and appear in another point on the map and having more freedom to explore caves and islands.
Fixes related issue: #39, #73

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Code change tested manually if not covered by automated tests
  • Pull request linked to one or more issues/stories
  • Acceptance criteria of the linked stories satisfied
  • Code change comprehended by those who approved it
  • State of target branch maintained or improved after the code change
  • Go to MainActivityTest in the Android App and uncommit @test
    Run test manually. Add a picture of the test result in the comments.
    Comment @test again to avoid future problems with the CI

@Dreia Dreia self-assigned this May 25, 2022
@Dreia Dreia added the Refactoring needed To refactor code for improvements to our system label May 25, 2022
increased the camera FAR to remove grey cutting planes
Related issue: #39
@Dreia
Copy link
Contributor Author

Dreia commented May 25, 2022

I finally managed to fix the camera grey cutting planes. This will work beautifully when the car climbs to the mountain to see the scenery.
Related issue: #39, #73

@Dreia Dreia added this to the Emulator milestone May 25, 2022
mod improvements
@Dreia
Copy link
Contributor Author

Dreia commented May 27, 2022

This is the final version of Race Mode, let me know if the clouds are ok. they are meant to guide the player towards safer routes.

@Dreia
Copy link
Contributor Author

Dreia commented May 27, 2022

Encountered a few issues with forking SMCE in order to finish the exploration mod and I am hoping to resolve them this morning
Related issue: #39

+ removed island.zip it can be downloaded from artifacts
+ enabled looping animation for airplane and clouds
@Dreia
Copy link
Contributor Author

Dreia commented May 27, 2022

Added an animation for the plane that will be in Race Mode as well in order to guide the player towards finishing the game, but also making the game more engaging
Related issue: #39, #73
For downloading the Island.zip you need to find the artifact created by the CI:

  • go to Actions and select build-island.zip
  • tick the three dots button on the right
  • select Summary on the left menu
  • go to Artifacts option in the top bar.

The plan is to improve the CI to attach this artifact to the release of the app in the Releases wiki page and also to update the Modding instructions to reflect that.
The Island.zip file on master is not updated and must be deleted.

@Dreia Dreia changed the title Fixed Finish Line position bug Exploration Mode and Race Mode May 27, 2022
Copy link
Contributor

@faisal1201 faisal1201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dreia I downloaded the Island.zip file from artifacts as you instructed and pasted it inside %APPDATA%\Godot\app_userdata\SMCE\mods (PC). But, i don't get the option to switch to isle environment anymore. Am I doing anything wrong?
image

@faisal1201
Copy link
Contributor

There is only one Island.pck file inside the zip file i downloaded from the artifacts . Shouldn't there be more files?
image

@RuthgerD
Copy link

the pck needs to be in the toplevel of the mods folder, i.e:
mods > island.pck

@faisal1201
Copy link
Contributor

faisal1201 commented May 27, 2022

@Dreia I can change the mod environment now . But, instead of putting the Island.zip file in the %APPDATA%\Godot\app_userdata\SMCE\mods ,I extracted the zip file and put the .pck file inside the directory as Ruthger pointed out. You might also need to update wiki page on modding instructions

Copy link
Contributor

@faisal1201 faisal1201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dreia can you update your user story #39 .As of now, I don't see that the acceptance criteria has been met. There wasn't any elevator in the mod. If you are planning to not have it ,then remember to update the acceptance criteria in the issue.
Acceptance criteria for #73 has been met.

@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

@Dreia I can change the mod environment now . But, instead of putting the Island.zip file in the %APPDATA%\Godot\app_userdata\SMCE\mods ,I extracted the zip file and put the .pck file inside the directory as Ruthger pointed out. You might also need to update wiki page on modding instructions

I see, I have modified it. Thanks

@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

The last version of the island.zip is here Go to artifacts and download. Then extract the archive and just fetch the .pck file.
References related issue: #39, #73

+ made a new mod with different starting point and option to get to more places on the island and on the other islands
@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

I have added the exploration mod as I have it now. It´s called Exploration/Exploration and you can just get the normal zip file in the Exploration folder
You can have it in the same folder with the Island.pck but you need a different profile to run it (make a new profile).
I kept the finish line for the moment but I can of course delete.
I will keep the user stories open for now cause I think I will have the elevator working by tomorrow.
Related issues: #39, #73.

@Dreia Dreia requested review from itsdanesh and safayoussef and removed request for restless-learner May 28, 2022 12:31
@Dreia Dreia removed High Priority Refactoring needed To refactor code for improvements to our system labels May 28, 2022
@Dreia Dreia requested a review from faisal1201 May 28, 2022 12:33
This was linked to issues May 28, 2022
@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

I forgot to say that if the exploration mod doesn't work for you you might need to install the SMCE-Godot release that I made from [here] (https://github.com/DIT113-V22/smce-gd-group-08/actions/runs/2400632985#artifacts). I don't think you will need it but if you do it only takes a minute to install and it works as an update to the official version so everything we have done so far is supported.

@faisal1201
Copy link
Contributor

I think you need to change the spawn location of the car in explorer mode because the current spawn location is on the sea where you can't actually drive.
image

@faisal1201
Copy link
Contributor

faisal1201 commented May 28, 2022

if you think the elevator is going to take some more time, then we can also discard it. You can just change the acceptance criteria of issue #39
I decided to give it until tomorrow early morning, if by then I still don't have it then we can of course proceed with the video as is. Hope that's ok

@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

I think you need to change the spawn location of the car in explorer mode because the current spawn location is on the sea where you can't actually drive.
image

You can actually drive on the sea. Enjoy!

@faisal1201
Copy link
Contributor

Alright, I'll try driving on the Sea

Use 'actions/upload-artifact@v2' to try to export without zipping
@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

I fixed the artifact problem. Now you can simply download the .pck here. I'll update the modding instructions as well

@Dreia
Copy link
Contributor Author

Dreia commented May 28, 2022

Now the CI produces the two .pck files and you can find them in the Actions tab (updated constantly) or in the releases page (not updated unless someone creates a new release).
Related issues: #73, #74

@Dreia Dreia linked an issue May 28, 2022 that may be closed by this pull request
Copy link
Contributor

@Quinstedt Quinstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptance criteria of issue #39 has been deleted, tho the problems encountered with the elevator.
The mood is working. It has been tested manually

@Quinstedt Quinstedt merged commit e653087 into master May 29, 2022
@faisal1201 faisal1201 deleted the Exploration-Mod branch May 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UserStories Userstories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exploration mode wiki Usability of Exploration Mode Exploration Mode Improvements
4 participants