Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] remove JobDB's site mask #7762

Merged
merged 7 commits into from
Oct 7, 2024
Merged

[9.0] remove JobDB's site mask #7762

merged 7 commits into from
Oct 7, 2024

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Aug 26, 2024 •
edited
Loading

  • add wiki
  • mod DiracX

BEGINRELEASENOTES

*WMS
CHANGE: removed JobDB's SiteMask and Logging

ENDRELEASENOTES

@fstagni fstagni force-pushed the 90_removeSiteMask branch 7 times, most recently from 43da1c7 to 10e7840 Compare August 28, 2024 18:53
@fstagni fstagni mentioned this pull request Aug 29, 2024
Merged
@fstagni fstagni force-pushed the 90_removeSiteMask branch from 10e7840 to 45d3a7d Compare August 29, 2024 10:36
@fstagni fstagni marked this pull request as ready for review August 29, 2024 13:26
@fstagni fstagni force-pushed the 90_removeSiteMask branch 2 times, most recently from e9085aa to 046dd7e Compare August 30, 2024 06:57
@fstagni fstagni force-pushed the 90_removeSiteMask branch 5 times, most recently from 2a60742 to 1252509 Compare September 11, 2024 17:51
@fstagni fstagni mentioned this pull request Sep 12, 2024
Merged
chaen
chaen reviewed Oct 2, 2024
View reviewed changes
src/DIRAC/DataManagementSystem/Client/test/Test_FTS3Objects.py
@@ -181,6 +172,20 @@ def monkeypatchForAllTest(monkeypatch):
lambda _self, _seName, _vo: S_OK(),
)

def mock_init(self, useProxy=False, vo=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that necessary here and below now ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before tests were never going through RSS for finding the status of a SE, now they do. So, some mocking of StorageFactory had to be added.

@fstagni
Copy link
Contributor Author

fstagni commented Oct 7, 2024

OK now? I will merge in an hour or 2

@fstagni fstagni merged commit 31c3f0c into DIRACGrid:integration Oct 7, 2024
24 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaen chaen chaen left review comments

@andresailer andresailer andresailer left review comments

@atsareg atsareg Awaiting requested review from atsareg atsareg is a code owner

Assignees
No one assigned
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fstagni @andresailer @chaen @DIRACGridBot