Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Lower log level for printing version in submitJob #7320

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

sfayer
Copy link
Member

@sfayer sfayer commented Nov 28, 2023

Hi,

We've noticed that dirac-wms-job-submit has started printing the DIRAC version number when it runs:

$ dirac-wms-job-submit test.jdl
<=====8.0.31=====>
JobID = 2081

I don't think this used to happen: This patch just lowers the log level to hide it by default. The actual log line has been in the DIRAC codebase for 16+ years, so I'm guessing it must be the logger set-up which changed.

Regards,
Simon

BEGINRELEASENOTES
*Interfaces
FIX: Lower log level for printing version in submitJob
ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Nov 28, 2023
fstagni
fstagni previously approved these changes Nov 28, 2023
@fstagni
Copy link
Contributor

fstagni commented Nov 28, 2023

pytest is failing. Checking... did you rebase already on the latest HEAD of rel-v8r0 branch?

@sfayer
Copy link
Member Author

sfayer commented Nov 28, 2023

Yes, this branch is completely up-to-date with rel-v8r0. Not sure what's up with the test, perhaps you could just close/reopen this pull and see if that clears it?

Regards,
Simon

@chrisburr
Copy link
Member

The new proxy generated in #7311 was only valid for 24 hours 🤦 I've pushed one that lasts a bit longer.

@chrisburr chrisburr merged commit 13128a2 into DIRACGrid:rel-v8r0 Nov 28, 2023
25 checks passed
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Nov 28, 2023
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Nov 28, 2023
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/7024969500

Successful:

  • integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants