Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HID_QUIRK_HIDINPUT_FORCE to fix #550 #553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use HID_QUIRK_HIDINPUT_FORCE to fix #550 #553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f3093
Use HID_QUIRK_HIDINPUT_FORCE (fixes #550).
tornaria Aug 4, 2021
f092709
Use suffix "Digitizer" for HID_DG_DIGITIZER
tornaria Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hid-uclogic-core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ static int uclogic_input_configured(struct hid_device *hdev,
case HID_GD_KEYPAD:
suffix = "Pad";
break;
case HID_DG_DIGITIZER:
suffix = "Digitizer";
break;
case HID_DG_PEN:
suffix = "Pen";
break;
Expand Down Expand Up @@ -203,6 +206,14 @@ static int uclogic_probe(struct hid_device *hdev,
#ifdef HID_QUIRK_NO_EMPTY_INPUT
hdev->quirks |= HID_QUIRK_NO_EMPTY_INPUT;
#endif
/*
* We must force HIDINPUT, since some devices are of class
* HID_DG_DIGITIZER, which is (incorrectly?) not considered as
* input by macro IS_INPUT_APPLICATION().
* With this quirk all devices are forced to go through
* hidinput_connect() to be configured as input devices.
*/
hdev->quirks |= HID_QUIRK_HIDINPUT_FORCE;

/* Allocate and assign driver data */
drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
Expand Down