Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use example values for JSON interfaces in examples #65

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

chrisvanrun
Copy link
Collaborator

Part of the pitch:

This PR uses the example values that @ammar257ammar nicely added for JSON CIVs. In theory, this makes every example now viable for direct upload.

It uses the example values:

  • For input values for algorithms
  • For output values for algorithms
  • For fictive algorithm output for local tests of evaluation methods
  • For values for value-kind CIVs in prediction.json of evaluation methods

To address formatting of very long example values (e.g. polygons/2D Bounding Boxes) all rendered/copied partial templates are now also covered by black. This has the nice benefit of cleaning up the formatting of the generated examples.

Copy link
Contributor

@amickan amickan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisvanrun chrisvanrun merged commit d1aceeb into main Oct 31, 2024
8 checks passed
@chrisvanrun chrisvanrun deleted the json-example-values branch October 31, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants