Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mha files impl #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mha files impl #2

wants to merge 5 commits into from

Conversation

krisssnv
Copy link
Collaborator

@krisssnv krisssnv commented Jan 5, 2025

No description provided.

@krisssnv krisssnv requested a review from fennievdg January 5, 2025 13:20
@krisssnv krisssnv marked this pull request as ready for review January 6, 2025 12:04
@fennievdg
Copy link
Collaborator

fennievdg commented Jan 8, 2025

Script looks clean, and it runs as expected nice job!
I see basically no differences in the results between what I ran and yours (see attached), but to try to reduce randomness as it is best practice, could you add a torch.seed(any number) in the appropriate files to try to control for randomness from pytorch operations? You can just add this at the top, one such file is serie.py. You can just check a bit with chatgpt which scripts it would make sense (based on their operations) to add a torch seed; always use the same number and make note of this number. No need to be very thorough about this; could be that serie.py is the only appropriate file.
comparison_results.csv

Can you remove the adding of .mha to the seriesinstanceuid in the SeriesInstanceUID collumn of the output?

Once these changes are made I can approve!

*General reminder, with you experiments on performance, please run each experiment 5x with that same seed just to demonstrate reliability of your results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants