Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install packages in docker container to enable flask profiling #351

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

adkinsjd
Copy link
Contributor

Currently setting FLASK_PROFILE=true when using the docker container fails due to missing packages.

This PR adds the packages necessary to run flask profiling.

They are unfortunately quite dated - these are the maximum versions that I found would succeed with no other code changes. I'm happy to modify if there is a clear path profiling with more up-to-date packages.

Copy link
Collaborator

@dionhaefner dionhaefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(I guess once more people start using those Docker images we should have them tested on CI but for now this should do.)

@dionhaefner dionhaefner merged commit 54d2919 into DHI:main Nov 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants