-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docker image #313
Create docker image #313
Conversation
Thanks for the PR. What's the concrete use case for this? It looks like it's meant for production, but why use |
The intention is to use the docker image in a containerized deployment. I am going to use that image with azure container apps. |
Codecov Report
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 52 52
Lines 2338 2338
Branches 476 476
=======================================
Hits 2294 2294
Misses 29 29
Partials 15 15 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks better now.
- Could we please move the makefile and dockerignore under a
docker/
subfolder to keep this self-contained? (You might have to move the build context one level deeper) - Please add a minimal example on how to use this to
docker/README.md
.
0b0259e
to
4a0ac35
Compare
Thanks @dionhaefner for the recommendations, I added them. |
4a0ac35
to
05d1b6f
Compare
LGTM, thanks |
Added code for creating a docker image to be used when deploying the terracotta server. It has been used in an azure container app and it had really good results.