Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default db connection timeout to 100 seconds #265

Closed
wants to merge 1 commit into from

Conversation

panakouris
Copy link
Contributor

I just noticed that in the last version it seems that from the time I run tc.get_driver() I have 10 seconds until the connection to the DB dies. I suggest that the default value should be much higher that 10 seconds. Set it to 100 for now.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #265 (bd28e23) into main (2e8bcdb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          49       49           
  Lines        2211     2211           
  Branches      310      310           
=======================================
  Hits         2184     2184           
  Misses         17       17           
  Partials       10       10           
Impacted Files Coverage Δ
terracotta/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8bcdb...bd28e23. Read the comment docs.

@dionhaefner
Copy link
Collaborator

This timeout should be the timeout for establishing a connection, not the time it's kept alive. Did the semantics change in the SQLalchemy port? @nickeopti

@panakouris
Copy link
Contributor Author

Hmmm, I think you are correct. I will dig further into it next week. But the connection errors I get are quite often at the moment. Can also be related to overused database.

@panakouris panakouris closed this May 2, 2022
@panakouris panakouris deleted the default-db-connection-timeout branch May 2, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants