Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pymysql 0.1.0 breaks context manager #185

Closed
j08lue opened this issue Sep 9, 2020 · 0 comments · Fixed by #229
Closed

pymysql 0.1.0 breaks context manager #185

j08lue opened this issue Sep 9, 2020 · 0 comments · Fixed by #229
Labels
plumbing Enhancements on the internal code structure

Comments

@j08lue
Copy link
Collaborator

j08lue commented Sep 9, 2020

In version 0.1.0, pymysql.connect is not a context manager, so our with won't work.

https://github.com/DHI-GRAS/terracotta/blob/ec351a05fd4fb76133219d62fdd1f5450f7abfff/terracotta/drivers/mysql.py#L260

There is an open PR fixing that PyMySQL/PyMySQL#886. Until it is merged, users should pip install pymysql==0.9.3.
@j08lue j08lue added the plumbing Enhancements on the internal code structure label Sep 9, 2020
dionhaefner added a commit that referenced this issue Oct 8, 2020
@dionhaefner
add maximum vesion for pymysql (#185)
8ce24af
@nickeopti nickeopti mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plumbing Enhancements on the internal code structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require pymysql>=1.0.0, which has a context managed connection DHI/terracotta
1 participant
@j08lue