change get_datasets default behavior

terracotta/drivers/sqlite.py

@@ -237,8 +237,11 @@ def _get_datasets(self, where: Optional[Tuple[Tuple[str, str], ...]],
         """Cache-backed version of get_datasets"""
         conn = self._connection
 
-        # explicitly cast to int to prevent SQL injection
-        page_query = f'LIMIT {int(limit)} OFFSET {int(page) * int(limit)}'
+        if limit is not None:
+            # explicitly cast parameters to int to prevent SQL injection
+            page_query = f'LIMIT {int(limit)} OFFSET {int(page) * int(limit)}'
+        else:
+            page_query = ''
 
         if where is None:
             rows = conn.execute(f'SELECT * FROM datasets {page_query}')
@@ -262,7 +265,7 @@ def keytuple(row: sqlite3.Row) -> Tuple[str, ...]:
     @requires_connection
     @convert_exceptions('Could not retrieve datasets')
     def get_datasets(self, where: Mapping[str, str] = None,
-                     page: int = 0, limit: int = 100) -> Dict[Tuple[str, ...], str]:
+                     page: int = 0, limit: int = None) -> Dict[Tuple[str, ...], str]:
         """Retrieve keys of datasets matching given pattern"""
         # make sure arguments are hashable
         if where is None:

tests/server/test_flask_api.py

@@ -48,6 +48,7 @@ def test_get_datasets(client, use_read_only_database):
     rv = client.get('/datasets')
     assert rv.status_code == 200
     datasets = json.loads(rv.data, object_pairs_hook=OrderedDict)['datasets']
+    assert len(datasets) == 3
     assert OrderedDict([('key1', 'val11'), ('akey', 'x'), ('key2', 'val12')]) in datasets