Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easy to use NetCDF for point data #500

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make it easy to use NetCDF for point data #500

wants to merge 5 commits into from

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Jan 22, 2025 •
edited
Loading

NetCDF makes it trivial to store coordinates and metadata.

ModelSkill should make use of this to avoid repeating this

The goal is to avoid lines like this:

o1 = ms.PointObservation('../data/SW/HKNA_Hm0.dfs0', x=4.2420, y=52.6887, name="HKNA")

and instead:

o1 = ms.PointObservation('../data/SW/HKNA_Hm0.nc')

How to create a NetCDF from Dfs0:
image

@ecomodeller ecomodeller marked this pull request as ready for review January 22, 2025 08:33
@jsmariegaard
Copy link
Member

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @jsmariegaard