Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 통계/피드백 api 연동 #42

Merged
merged 16 commits into from
Dec 6, 2023
Merged

Conversation

Dan2dani
Copy link
Member

@Dan2dani Dan2dani commented Dec 5, 2023

📌 관련 이슈

📷 screenshot

나중에 올릴게요

📝 Work Desciption

통계 / 피드백 api 연동

🥹 Uncompleted Task

  • 저번주차,다음주차 피드백 보기

@Dan2dani Dan2dani requested a review from l2zh December 5, 2023 03:59
@Dan2dani Dan2dani self-assigned this Dec 5, 2023
@Dan2dani Dan2dani force-pushed the feat-chart-api-connection branch from 0ef850f to f360b6b Compare December 5, 2023 04:02
Copy link
Collaborator

@l2zh l2zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"허가한다"

private fun collectData() {
viewModel.feedBackContent.flowWithLifecycle(lifecycle).onEach { feedBackContent ->
with(binding) {
binding.tvFeedbackTitle.text = String.format("%d주차 피드백", feedBackContent?.week)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스트링 추출 해주세염ㅋㅋ

}.launchIn(lifecycleScope)
}

private fun setPriorityRateBarChart(barChart: BarChart, barList: ArrayList<BarEntry>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신기하네용

}
}.launchIn(lifecycleScope)
}

// override fun onDestroyView() {
// binding.vpChart.adapter = null
// super.onDestroyView()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘는 왜 주석처리 되어있죠?

viewModel.feedBackContent.flowWithLifecycle(lifecycle).onEach { feedBackContent ->
if (feedBackContent != null) {
binding.tvChartTitle.text =
String.format("%d월 %d주차 통계/피드백", feedBackContent.month, feedBackContent.week)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅇ

@@ -31,6 +40,15 @@ class ChartFragment : BindingFragment<FragmentChartBinding>(R.layout.fragment_ch
}.attach()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 탭 레이아웃 이렇게 쓰는군요

val rateString = String.format("%d%%", rateOfChange)
val formattedString = getString(
R.string.chart_statistic_achievement_rate_des,
Html.fromHtml(rateString, Html.FROM_HTML_MODE_LEGACY)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대박이다 이거ㅋㅋ

@Dan2dani Dan2dani force-pushed the feat-chart-api-connection branch from f360b6b to dc4bbcc Compare December 5, 2023 15:33
@Dan2dani Dan2dani merged commit 4d92a1e into develop Dec 6, 2023
1 check passed
@l2zh l2zh deleted the feat-chart-api-connection branch December 6, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 통계 / 피드백 api 연동
2 participants