Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General updates to allow .env configuraiton and update dependencies #87

Merged
merged 2 commits into from
Mar 1, 2024
Merged

General updates to allow .env configuraiton and update dependencies #87

merged 2 commits into from
Mar 1, 2024

Conversation

mattonfoot
Copy link
Contributor

Context

Lots of outdated packages need updating.

Changes proposed in this pull request

  • ran 'bundle update';
  • added .gitignore entry to hide .env file from git commits as app won't run spec tests unless some sort of ORDNANCE_SURVEY_API_KEY is set in the environment.

@github-actions GitHub Actions
Copy link

Review app deployed to https://cpd-tsh-review-87.test.teacherservices.cloud/

@mattonfoot mattonfoot self-assigned this Feb 19, 2024
@mattonfoot mattonfoot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Feb 19, 2024
peteryates
peteryates approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@peteryates peteryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@slawosz slawosz merged commit 108d557 into main Mar 1, 2024
20 of 27 checks passed
@slawosz slawosz deleted the dependency-updates branch March 1, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteryates peteryates peteryates approved these changes

@Lockyy Lockyy Awaiting requested review from Lockyy

@leoapost leoapost Awaiting requested review from leoapost

@javier-npq javier-npq Awaiting requested review from javier-npq

@slawosz slawosz Awaiting requested review from slawosz

Assignees

@mattonfoot mattonfoot

Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattonfoot @peteryates @slawosz