Preproduction database restore #2482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neillturner
requested review from
shaheislamdfe
and removed request for
a team
shaheislamdfe
approved these changes
Nov 1, 2024
saliceti
reviewed
Nov 4, 2024
| @@ -45,7 +46,7 @@ jobs: | |||
| - name: Set environment variables | |||
| run: | | |||
| source global_config/${{ inputs.environment }}.sh | |||
| tf_vars_file=${{ env.TF_VARS_PATH }}/${{ inputs.environment }}/variables.tfvars.json | |||
| tf_vars_file=${{ env.TF_VARS_PATH }}/${{ env.ENVIRONMENT }}/variables.tfvars.json | |||
There was a problem hiding this comment.
${{ env.ENVIRONMENT }} is not set at this point
But $ENVIRONMENT should work
saliceti
reviewed
Nov 4, 2024
| @@ -64,7 +65,7 @@ jobs: | |||
| with: | |||
| storage-account: ${{ env.STORAGE_ACCOUNT_NAME }} | |||
| resource-group: ${{ env.RESOURCE_GROUP_NAME }} | |||
| app-name: ${{ env.SERVICE_NAME }}-${{ inputs.environment }}-web | |||
| app-name: ${{ env.SERVICE_NAME }}-${{ env.ENVIRONMENT }}-web | |||
There was a problem hiding this comment.
ENVIRONMENT is not set in GITHUB_ENV
saliceti
reviewed
Nov 4, 2024
.github/workflows/database-ptr.yml
Outdated
| @@ -45,7 +46,7 @@ jobs: | |||
| - name: Set environment variables | |||
| run: | | |||
| source global_config/${{ inputs.environment }}.sh | |||
| tf_vars_file=${{ env.TF_VARS_PATH }}/${{ inputs.environment }}/variables.tfvars.json | |||
| tf_vars_file=${{ env.TF_VARS_PATH }}/${{ env.ENVIRONMENT }}/variables.tfvars.json | |||
There was a problem hiding this comment.
${{ env.ENVIRONMENT }} is not set at this point
But $ENVIRONMENT should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
support restore and restore to point in time in preproduction for DR testing
Changes proposed in this pull request
add preprod to database_restore and database_ptr workflow
Guidance to review
Restore Point in Time
gh workflow run "Restore database from point in time to new database server" -r database-restore -f environment=preproduction -f restore-time=2024-10-29T06:00:00
see https://github.com/DFE-Digital/apply-for-qualified-teacher-status/actions/runs/11666600131
Restore from backup
gh workflow run "Restore database from Azure storage" -r database-restore -f environment=preproduction -f backup-file=afqts_pp_adhoc_2024-11-01.sql.gz
see https://github.com/DFE-Digital/apply-for-qualified-teacher-status/actions/runs/11666736478
Link to Trello card
AFQTS: database restore and ptr to preprod
Checklist