DFE analytics terraform module #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
force-pushed
the
2041-configure-bigquery-in-the-terraform-module
branch
from
cbe8985 to
cc3f80e
Compare
|
Review app deployed to https://apply-for-qts-review-2441-web.test.teacherservices.cloud/personas |
4 tasks
saliceti
force-pushed
the
2041-configure-bigquery-in-the-terraform-module
branch
from
8adb74c to
aebfcf3
Compare
saliceti
force-pushed
the
2041-configure-bigquery-in-the-terraform-module
branch
from
bbd493a to
48ba89e
Compare
saliceti
force-pushed
the
2041-configure-bigquery-in-the-terraform-module
branch
from
48ba89e to
f6c7ded
Compare
Permissions are now added explicitly. See: https://github.com/DFE-Digital/terraform-modules/tree/main/aks/dfe_analytics#authentication---github-actions
saliceti
force-pushed
the
2041-configure-bigquery-in-the-terraform-module
branch
from
591c6b4 to
9ccde5e
Compare
saliceti
force-pushed
the
2041-configure-bigquery-in-the-terraform-module
branch
from
9ccde5e to
8aa1af3
Compare
RMcVelia
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configure workload identity federation for Google cloud to avoid using a permanent key
Add the dfe_analytics terraform module and authorise the deployment workflow to Google cloud
Enable deferated for review app, but leave biquery disabled for review apps
How to review
Check review app events are sent to Bigquery when bigquery is enabled
Before merging
After merging