Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logic for returning trusts and associated address information #324

Merged

Conversation

blakebyron-nimble
Copy link
Contributor

What is the change?

  • Fix issue when returning trust address information via the trusts endpoint . Incorrect field used when filtering trusts linked to a parent group.
  • Added associated test following similar format to existing tests.

Why do we need the change?

Ensure address information is returned by the trusts endpoint and can be consumed by other services

What is the impact?
Enable Record Concerns to display town within trust search page. The town is displayed to users enabling differentiation between trusts with the same name but in different parts of the country.

Azure DevOps Ticket

https://dfe-gov-uk.visualstudio.com/Academies-and-Free-Schools-SIP/_boards/board/t/Concerns%20Casework/Stories/?workitem=125531

@blakebyron-nimble blakebyron-nimble added the bug Something isn't working label Apr 18, 2023
@blakebyron-nimble blakebyron-nimble self-assigned this Apr 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blakebyron-nimble blakebyron-nimble marked this pull request as ready for review April 18, 2023 10:59
@blakebyron-nimble blakebyron-nimble merged commit 71cd9c8 into main Apr 19, 2023
@DrizzlyOwl DrizzlyOwl deleted the feature/125531-trust-search-address-not-returned branch August 30, 2023 10:44
Stretch96 pushed a commit that referenced this pull request Aug 30, 2023
…address-not-returned

Fixed logic for returning trusts and associated address information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants