Merge pull request #318 from DFE-Digital/124178/project-created-on-date

Adds a CreatedOn column to the AcademyTransfersProject table
DFE-Digital · Mar 24, 2023 · 8aa09fe · 8aa09fe
2 parents d49c5b0 + bb032da
commit 8aa09fe
Show file tree

Hide file tree

Showing 6 changed files with 926 additions and 353 deletions.
diff --git a/TramsDataApi.Test/Factories/AcademyTransferProjectFactoryTests.cs b/TramsDataApi.Test/Factories/AcademyTransferProjectFactoryTests.cs
@@ -269,7 +269,9 @@ public void ReturnsUpdatedAcademyTransferProject_WhenUpdating_IfRequestHasUpdate
                 HasTargetDateForTransfer = academyTransferProject.HasTargetDateForTransfer,
                 AssignedUserEmailAddress = academyTransferProject.AssignedUserEmailAddress,
                 AssignedUserFullName = academyTransferProject.AssignedUserFullName,
-                AssignedUserId = academyTransferProject.AssignedUserId
+                AssignedUserId = academyTransferProject.AssignedUserId,
+
+                CreatedOn = academyTransferProject.CreatedOn
             };
 
             var result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
@@ -364,7 +366,9 @@ public void ReturnsUpdatedAcademyTransferProject_WhenUpdating_AndUpdatesTheListO
                 HasTargetDateForTransfer = academyTransferProject.HasTargetDateForTransfer,
                 AssignedUserEmailAddress = academyTransferProject.AssignedUserEmailAddress,
                 AssignedUserFullName = academyTransferProject.AssignedUserFullName,
-                AssignedUserId = academyTransferProject.AssignedUserId
+                AssignedUserId = academyTransferProject.AssignedUserId,
+
+                CreatedOn = academyTransferProject.CreatedOn
             };
 
             var result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
@@ -451,7 +455,9 @@ public void ReturnsUpdatedAcademyTransferProject_WhenUpdating_IfRequestHasUpdate
                 HasTargetDateForTransfer = academyTransferProject.HasTargetDateForTransfer,
                 AssignedUserEmailAddress = academyTransferProject.AssignedUserEmailAddress,
                 AssignedUserFullName = academyTransferProject.AssignedUserFullName,
-                AssignedUserId = academyTransferProject.AssignedUserId
+                AssignedUserId = academyTransferProject.AssignedUserId,
+
+                CreatedOn = academyTransferProject.CreatedOn
             };
 
             var result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
@@ -478,56 +484,58 @@ public void ReturnsUpdatedAcademyTransferProject_WhenUpdating_IfRequestIsToSetDa
 
             var expected = new AcademyTransferProjects
             {
-                Id = academyTransferProject.Id,
-                Urn = academyTransferProject.Urn,
-                ProjectReference = academyTransferProject.ProjectReference,
-                OutgoingTrustUkprn = academyTransferProject.OutgoingTrustUkprn,
-                ProjectRationale = academyTransferProject.ProjectRationale,
-                TransferringAcademies = academyTransferProject.TransferringAcademies,
-                WhoInitiatedTheTransfer = academyTransferProject.WhoInitiatedTheTransfer,
-                TargetDateForTransfer = null,
-                RddOrEsfaIntervention = academyTransferProject.RddOrEsfaIntervention,
-                RddOrEsfaInterventionDetail = academyTransferProject.RddOrEsfaInterventionDetail,
-                TypeOfTransfer = academyTransferProject.TypeOfTransfer,
-                OtherTransferTypeDescription = academyTransferProject.OtherTransferTypeDescription,
-                TransferFirstDiscussed = null,
-                HtbDate = null,
-                TrustSponsorRationale = academyTransferProject.TrustSponsorRationale,
-                State = academyTransferProject.State,
-                Status = academyTransferProject.Status,
-                Author = academyTransferProject.Author,
-                Recommendation = academyTransferProject.Recommendation,
-                AnyRisks = academyTransferProject.AnyRisks,
-                HighProfileShouldBeConsidered = academyTransferProject.HighProfileShouldBeConsidered,
-                HighProfileFurtherSpecification = academyTransferProject.HighProfileFurtherSpecification,
-                ComplexLandAndBuildingShouldBeConsidered =
+               Id = academyTransferProject.Id,
+               Urn = academyTransferProject.Urn,
+               ProjectReference = academyTransferProject.ProjectReference,
+               OutgoingTrustUkprn = academyTransferProject.OutgoingTrustUkprn,
+               ProjectRationale = academyTransferProject.ProjectRationale,
+               TransferringAcademies = academyTransferProject.TransferringAcademies,
+               WhoInitiatedTheTransfer = academyTransferProject.WhoInitiatedTheTransfer,
+               TargetDateForTransfer = null,
+               RddOrEsfaIntervention = academyTransferProject.RddOrEsfaIntervention,
+               RddOrEsfaInterventionDetail = academyTransferProject.RddOrEsfaInterventionDetail,
+               TypeOfTransfer = academyTransferProject.TypeOfTransfer,
+               OtherTransferTypeDescription = academyTransferProject.OtherTransferTypeDescription,
+               TransferFirstDiscussed = null,
+               HtbDate = null,
+               TrustSponsorRationale = academyTransferProject.TrustSponsorRationale,
+               State = academyTransferProject.State,
+               Status = academyTransferProject.Status,
+               Author = academyTransferProject.Author,
+               Recommendation = academyTransferProject.Recommendation,
+               AnyRisks = academyTransferProject.AnyRisks,
+               HighProfileShouldBeConsidered = academyTransferProject.HighProfileShouldBeConsidered,
+               HighProfileFurtherSpecification = academyTransferProject.HighProfileFurtherSpecification,
+               ComplexLandAndBuildingShouldBeConsidered =
                     academyTransferProject.ComplexLandAndBuildingShouldBeConsidered,
-                ComplexLandAndBuildingFurtherSpecification =
+               ComplexLandAndBuildingFurtherSpecification =
                     academyTransferProject.ComplexLandAndBuildingFurtherSpecification,
-                FinanceAndDebtShouldBeConsidered = academyTransferProject.FinanceAndDebtShouldBeConsidered,
-                FinanceAndDebtFurtherSpecification = academyTransferProject.FinanceAndDebtFurtherSpecification,
-                OtherRisksShouldBeConsidered = academyTransferProject.OtherRisksShouldBeConsidered,
-                OtherRisksFurtherSpecification = academyTransferProject.OtherRisksFurtherSpecification,
-                OtherBenefitValue = academyTransferProject.OtherBenefitValue,
-                EqualitiesImpactAssessmentConsidered = academyTransferProject.EqualitiesImpactAssessmentConsidered,
-                IncomingTrustAgreement = academyTransferProject.IncomingTrustAgreement,
-                DiocesanConsent = academyTransferProject.DiocesanConsent,
-                OutgoingTrustConsent = academyTransferProject.OutgoingTrustConsent,
-                FeatureSectionIsCompleted = academyTransferProject.FeatureSectionIsCompleted,
-                BenefitsSectionIsCompleted = academyTransferProject.BenefitsSectionIsCompleted,
-                LegalRequirementsSectionIsCompleted = academyTransferProject.LegalRequirementsSectionIsCompleted,
-                RationaleSectionIsCompleted = academyTransferProject.RationaleSectionIsCompleted,
-                AcademyTransferProjectIntendedTransferBenefits =
+               FinanceAndDebtShouldBeConsidered = academyTransferProject.FinanceAndDebtShouldBeConsidered,
+               FinanceAndDebtFurtherSpecification = academyTransferProject.FinanceAndDebtFurtherSpecification,
+               OtherRisksShouldBeConsidered = academyTransferProject.OtherRisksShouldBeConsidered,
+               OtherRisksFurtherSpecification = academyTransferProject.OtherRisksFurtherSpecification,
+               OtherBenefitValue = academyTransferProject.OtherBenefitValue,
+               EqualitiesImpactAssessmentConsidered = academyTransferProject.EqualitiesImpactAssessmentConsidered,
+               IncomingTrustAgreement = academyTransferProject.IncomingTrustAgreement,
+               DiocesanConsent = academyTransferProject.DiocesanConsent,
+               OutgoingTrustConsent = academyTransferProject.OutgoingTrustConsent,
+               FeatureSectionIsCompleted = academyTransferProject.FeatureSectionIsCompleted,
+               BenefitsSectionIsCompleted = academyTransferProject.BenefitsSectionIsCompleted,
+               LegalRequirementsSectionIsCompleted = academyTransferProject.LegalRequirementsSectionIsCompleted,
+               RationaleSectionIsCompleted = academyTransferProject.RationaleSectionIsCompleted,
+               AcademyTransferProjectIntendedTransferBenefits =
                     academyTransferProject.AcademyTransferProjectIntendedTransferBenefits,
-                HasTransferFirstDiscussedDate = false,
-                HasHtbDate = false,
-                HasTargetDateForTransfer = false,
-                AssignedUserEmailAddress = academyTransferProject.AssignedUserEmailAddress,
-                AssignedUserFullName = academyTransferProject.AssignedUserFullName,
-                AssignedUserId = academyTransferProject.AssignedUserId
+               HasTransferFirstDiscussedDate = false,
+               HasHtbDate = false,
+               HasTargetDateForTransfer = false,
+               AssignedUserEmailAddress = academyTransferProject.AssignedUserEmailAddress,
+               AssignedUserFullName = academyTransferProject.AssignedUserFullName,
+               AssignedUserId = academyTransferProject.AssignedUserId,
+
+               CreatedOn = academyTransferProject.CreatedOn
             };
 
-            var result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
+         var result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
 
             result.Should().BeEquivalentTo(expected);
         }
@@ -604,10 +612,12 @@ public void ReturnsOriginalAcademyTransferProjectWithDatesSetToNull_WhenUpdating
                 HasTargetDateForTransfer = false,
                 AssignedUserEmailAddress = academyTransferProject.AssignedUserEmailAddress,
                 AssignedUserFullName = academyTransferProject.AssignedUserFullName,
-                AssignedUserId = academyTransferProject.AssignedUserId
+                AssignedUserId = academyTransferProject.AssignedUserId,
+
+                CreatedOn = academyTransferProject.CreatedOn
             };
 
-            var result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
+            AcademyTransferProjects result = AcademyTransferProjectFactory.Update(academyTransferProject, updateRequest);
 
             result.Should().BeEquivalentTo(expected);
         }

diff --git a/TramsDataApi.Test/integration_settings.json b/TramsDataApi.Test/integration_settings.json
@@ -8,7 +8,7 @@
   },
   "AllowedHosts": "*",
   "ApiKeys": ["{\"userName\": \"Test User\", \"apiKey\": \"testing-api-key\"}"],
-  "ConnectionStrings": {
-    "DefaultConnection": "Server=127.0.0.1,1433;Database=sip;User Id=sa;TrustServerCertificate=True;Password=Your_password123"
-  }
+   "ConnectionStrings": {
+      "DefaultConnection": "Server=127.0.0.1,1433;Database=sip;User Id=sa;TrustServerCertificate=True;Password=StrongPassword905"
+   }
 }
diff --git a/TramsDataApi/DatabaseModels/AcademyTransferProjects.cs b/TramsDataApi/DatabaseModels/AcademyTransferProjects.cs
@@ -61,7 +61,7 @@ public AcademyTransferProjects()
         public bool? LegalRequirementsSectionIsCompleted { get; set; }
         public bool? FeatureSectionIsCompleted { get; set; }
         public bool? BenefitsSectionIsCompleted { get; set; }
-        public bool? RationaleSectionIsCompleted { get; set; }        
+        public bool? RationaleSectionIsCompleted { get; set; }
         public string AssignedUserFullName { get; set; }
         public string AssignedUserEmailAddress { get; set; }
         public Guid? AssignedUserId { get; set; }
@@ -70,5 +70,7 @@ public virtual ICollection<AcademyTransferProjectIntendedTransferBenefits>
             AcademyTransferProjectIntendedTransferBenefits { get; set; }
 
         public virtual ICollection<TransferringAcademies> TransferringAcademies { get; set; }
+
+        public DateTime CreatedOn { get; set; }
     }
 }